New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate CircuitBreakerRpcClient.newPerHostAndMethodDecorator() #3249
Deprecate CircuitBreakerRpcClient.newPerHostAndMethodDecorator() #3249
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot, @KarboniteKream!
core/src/main/java/com/linecorp/armeria/client/circuitbreaker/CircuitBreakerRpcClient.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #3249 +/- ##
============================================
+ Coverage 74.05% 74.07% +0.01%
- Complexity 12999 13000 +1
============================================
Files 1133 1134 +1
Lines 49197 49213 +16
Branches 6259 6255 -4
============================================
+ Hits 36435 36456 +21
- Misses 9546 9551 +5
+ Partials 3216 3206 -10 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! @KarboniteKream 🙇♂️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot, @KarboniteKream! No more broken windows 🙇
Motivation
newPerHostAndMethodDecorator()
, but the method inCircuitBreakerRpcClient
hasn't been marked as deprecatedModifications
CircuitBreakerRpcClient.newPerHostAndMethodDecorator()
Result