Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate CircuitBreakerRpcClient.newPerHostAndMethodDecorator() #3249

Merged

Conversation

KarboniteKream
Copy link
Member

Motivation

Modifications

  • Deprecate CircuitBreakerRpcClient.newPerHostAndMethodDecorator()
  • Update wrong PR link in release notes
  • Update documentation

Result

  • Method deprecations are consistent

Copy link
Member

@minwoox minwoox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, @KarboniteKream!

@codecov
Copy link

codecov bot commented Dec 28, 2020

Codecov Report

Merging #3249 (bf6907f) into master (ccff172) will increase coverage by 0.01%.
The diff coverage is 86.95%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3249      +/-   ##
============================================
+ Coverage     74.05%   74.07%   +0.01%     
- Complexity    12999    13000       +1     
============================================
  Files          1133     1134       +1     
  Lines         49197    49213      +16     
  Branches       6259     6255       -4     
============================================
+ Hits          36435    36456      +21     
- Misses         9546     9551       +5     
+ Partials       3216     3206      -10     
Impacted Files Coverage Δ Complexity Δ
...ia/client/circuitbreaker/CircuitBreakerClient.java 83.07% <ø> (ø) 26.00 <0.00> (ø)
...client/circuitbreaker/CircuitBreakerRpcClient.java 80.95% <ø> (ø) 10.00 <0.00> (ø)
...spring/ArmeriaServerGracefulShutdownLifecycle.java 70.00% <70.00%> (ø) 5.00 <5.00> (?)
...dpoint/healthcheck/HealthCheckedEndpointGroup.java 82.71% <100.00%> (+0.55%) 22.00 <0.00> (+1.00)
...p/armeria/common/metric/MeterIdPrefixFunction.java 94.11% <100.00%> (+0.78%) 7.00 <1.00> (+1.00)
...meria/spring/AbstractArmeriaAutoConfiguration.java 75.00% <100.00%> (+0.58%) 13.00 <1.00> (+1.00)
...p/armeria/client/endpoint/OrElseEndpointGroup.java 54.28% <0.00%> (-14.29%) 8.00% <0.00%> (-3.00%)
...om/linecorp/armeria/client/HttpSessionHandler.java 71.59% <0.00%> (-9.47%) 49.00% <0.00%> (-5.00%)
...rp/armeria/common/stream/StreamMessageWrapper.java 86.95% <0.00%> (-3.96%) 11.00% <0.00%> (ø%)
...eria/internal/common/DefaultSplitHttpResponse.java 77.38% <0.00%> (-2.86%) 14.00% <0.00%> (ø%)
... and 53 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea4e7f5...bf6907f. Read the comment docs.

Copy link
Contributor

@ikhoon ikhoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! @KarboniteKream 🙇‍♂️

@ikhoon ikhoon removed the defect label Dec 29, 2020
Copy link
Member

@trustin trustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, @KarboniteKream! No more broken windows 🙇

@trustin trustin merged commit 05728d1 into line:master Jan 5, 2021
@KarboniteKream KarboniteKream deleted the fix/circuit-breaker-per-host-and-method branch January 5, 2021 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants