Fix a bug where an IllegalStateException is raised on a non-ready EndpointGroup
#3338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…EndpointGroup` Motivation: If an `EndpointGroup` is not initialized with initial values, a gRPC client will raise an `IllegalStateException` with the following message: ```java io.grpc.internal.ServerImpl$JumpToApplicationThreadServerStreamListener$1HalfClosed@3830513a java.lang.IllegalStateException: Should call init(endpoint) before invoking this method. ``` A `WebClient` waits a connection timeout for the `EndpointGroup` to have at least one Endpoint. However, a gRPC client does not wait for the `EndPointGroup` and start a gRPC request immediately. Modifications: - Add `DefaultClientRequestContext.whenIntialized()` which completes when a `ctx` is initialized with an `EndpointGroup`. - Defer a gRPC call until a `whenIntialized()` is completed. Result: - You no longer see an `IllegalStateException` if a gRPC call is sent to a non-ready `EndpointGroup` - Fixes line#3332
Codecov Report
@@ Coverage Diff @@
## master #3338 +/- ##
============================================
- Coverage 74.17% 74.13% -0.05%
- Complexity 13255 13269 +14
============================================
Files 1158 1158
Lines 50536 50597 +61
Branches 6469 6485 +16
============================================
+ Hits 37483 37508 +25
- Misses 9743 9774 +31
- Partials 3310 3315 +5 Continue to review full report at Codecov.
|
minwoox
reviewed
Feb 9, 2021
core/src/main/java/com/linecorp/armeria/client/DefaultClientRequestContext.java
Show resolved
Hide resolved
grpc/src/main/java/com/linecorp/armeria/internal/client/grpc/ArmeriaClientCall.java
Outdated
Show resolved
Hide resolved
grpc/src/main/java/com/linecorp/armeria/internal/client/grpc/ArmeriaClientCall.java
Outdated
Show resolved
Hide resolved
trustin
reviewed
Feb 10, 2021
core/src/main/java/com/linecorp/armeria/client/DefaultClientRequestContext.java
Show resolved
Hide resolved
| } | ||
|
|
||
| private void execute(Runnable task) { | ||
| if (endpointInitialized || ctx.whenInitialized().isDone()) { |
There was a problem hiding this comment.
We could use assert for this condition if we always guard this method with needsDirectInvocation().
There was a problem hiding this comment.
endpointInitialized could be either true, false here.
Because endpointInitialized || ctx.whenInitialized().isDone() and ctx.eventLoop().inEventLoop() are connected by && condition in needsDirectInvocation().
There was a problem hiding this comment.
Ah, indeed. Sorry for a bad comment 😅
trustin
changed the title
IllegalStateException is raised on a non-ready `…IllegalStateException is raised on a non-ready EndpointGroup
|
Thanks, @ikhoon! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…EndpointGroup`
Motivation:
If an
EndpointGroupis not initialized with initial values,a gRPC client will raise an
IllegalStateExceptionwith the following message:A
WebClientwaits a connection timeout for theEndpointGroupto have at least one Endpoint by @trustin's work (#2837)However, a gRPC client does not wait for the
EndPointGroupand start a gRPC request immediately.Modifications:
DefaultClientRequestContext.whenIntialized()which completeswhen a
ctxis initialized with anEndpointGroup.whenIntialized()is completed.Result:
IllegalStateExceptionif a gRPC call is sent to a non-readyEndpointGroupIllegalStateExceptionwhen making a gRPC call to a non-readyEndpointGroup. #3332