New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the scalapb json marshaller for sealed-oneof messages #3342
Conversation
…sage for a GeneratedSealedOneOf message
.../scalapb_2.13/src/main/scala/com/linecorp/armeria/common/scalapb/ScalaPbJsonMarshaller.scala
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #3342 +/- ##
============================================
+ Coverage 74.16% 74.18% +0.02%
- Complexity 13276 13290 +14
============================================
Files 1158 1159 +1
Lines 50626 50740 +114
Branches 6491 6504 +13
============================================
+ Hits 37548 37643 +95
- Misses 9765 9778 +13
- Partials 3313 3319 +6 Continue to review full report at Codecov.
|
@andrew-teirney Gentle ping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @andrew-teirney and @ikhoon !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! @andrew-teirney
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @andrew-teirney and @ikhoon !!!
When returning a ScalaPB message of the
sealed-oneof
flavour,the JSON marshaller does not marshal the wrapping message.
This changeset corrects that by detecting the case where the value passed in
is a
GeneratedSealedOneof
, and then marshalls the container message.