Add overview page to show service description in DocService #4537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dogacel
requested review from
ikhoon,
jrhee17,
minwoox and
trustin
as code owners
Codecov ReportBase: 74.08% // Head: 74.07% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #4537 +/- ##
============================================
- Coverage 74.08% 74.07% -0.01%
+ Complexity 18190 18180 -10
============================================
Files 1537 1537
Lines 67432 67469 +37
Branches 8533 8537 +4
============================================
+ Hits 49959 49980 +21
- Misses 13401 13414 +13
- Partials 4072 4075 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
jrhee17
reviewed
Nov 18, 2022
ikhoon
reviewed
Nov 22, 2022
| data.map((service) => ( | ||
| <TableRow key={service.name}> | ||
| <TableCell> | ||
| <code>{service.name}</code> |
There was a problem hiding this comment.
This is so nice. How about adding a hashtag to each service name and linking to the tag?
There was a problem hiding this comment.
I did not get this, how do I add a hashtag to each service name, and where it would link?
There was a problem hiding this comment.
I thought we can add a tag to this line.
Anyway, never mind. It looks good as is. We may add a dedicated page for each service that may be linked from this overview page later.
|
Bump |
minwoox
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Currently no page shows service description / documentation info.
Modifications:
overviewpage to the top levelservicesdropdown too see all services and their descriptions in a single page.Result:
DocServiceGRPC Service comments are not displayed anywhere #4480