Override HttpRequestDecoder.createMessage() for perfomance

[minwoox]

@ikhoon suggested this:
If we override HttpRequestDecoder.createMessage() and provide our own implementation of HttpMessage, we can covert Netty HTTP 1 headers to Armeria headers with zero-copy.
#3904 (comment)

[echo304]

I checked the source code so that I handle this issue but I couldn't find any relevant code like HttpServerCodec, HttpServerRequestDecoder, extending HttpRequestDecoder.
Is this issue still feasible? 🤔

[minwoox]

Thanks for your interest. 😆

HttpServerCodec is a class from Netty:

armeria/core/src/main/java/com/linecorp/armeria/server/HttpServerPipelineConfigurator.java

Line 524 in 6b6c0b0

p.addLast(new HttpServerCodec(

If we override HttpRequestDecoder.createMessage(),
https://github.com/netty/netty/blob/f67a55609d252e0eac9707df51997cc79ed22093/codec-http/src/main/java/io/netty/handler/codec/http/HttpRequestDecoder.java#L151
we can use our own header implementation.
https://github.com/netty/netty/blob/fde50fd204c00f59dc8e234952b622eff20025c6/codec-http/src/main/java/io/netty/handler/codec/http/HttpObjectDecoder.java#L630

[echo304]

So, idea might be like...

1. Implement ArmeriaHttpRequestDecoder which extends HttpObjectDecoder and override createMessage logic
2. Implement Armeria's custom HttpServerCodec which extends CombinedChannelDuplexHandler<ArmeriaHttpRequestDecoder, HttpResponseEncoder> and implements HttpServerUpgradeHandler.SourceCodec
3. Replace here with ArmeriaHttpServerCodec that is implemented above.

   armeria/core/src/main/java/com/linecorp/armeria/server/HttpServerPipelineConfigurator.java

   Line 524 in 6b6c0b0

   p.addLast(new HttpServerCodec(

Does it make sense to you? 😏
@minwoox

[echo304]

Oh, it seems like you already tried to fork netty's HttpServerCodec from here

🤔

[minwoox]

Oh, it seems like you already tried to fork netty's HttpServerCodec from here

Yes, I have tried but I reverted it because I didn't have to for my WebSocket PR.
So, please go ahead. 😉