Fix NullPointerException in FuseableStreamMessage
#4859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related issue: line#4852 Motivation: `FuseableStreamMessage.collect()` throws a NPE when only `mapError()` is applied to a normal `StreamMessage`. ``` StreamMessage.of(1, 2, 3, 4) .mapError(IllegalStateException::new) // Raises a NullPointerException .collect().join(); ``` `function` field in `FuseableStreamMessage` can be null if no `map()` is applied to `FuseableStreamMessage`. https://github.com/line/armeria/blob/871d87297e4d051241589cb1ae95641cbc83f880/core/src/main/java/com/linecorp/armeria/common/stream/FuseableStreamMessage.java#L162 The problem only happens when `collect()` method is called. `subscribe()` method already takes the case into account. Modifications: - Use the original object as is if `function` is null. Result: - You no longer see `NullPointerException` when `.mapError()` is applied to `StreamMessage` - Closes line#4852
|
Thanks @ikhoon for the quick fix (which LGTM)! Before we upgrade our Armeria dependency to pick up this fix, is adding a no-op |
|
Right. Adding |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #4852
Motivation:
FuseableStreamMessage.collect()throws aNPEwhen onlymapError()is applied to a normalStreamMessage.The
functionfield inFuseableStreamMessagecan be null if nomap()is applied toFuseableStreamMessage.armeria/core/src/main/java/com/linecorp/armeria/common/stream/FuseableStreamMessage.java
Line 162 in 871d872
The problem only happens when
collect()method is called.subscribe()method already takes the case into account.Modifications:
functionis null.Result:
NullPointerExceptionwhen.mapError()is applied toStreamMessageNPEonHttpResponsecallback In gRPC client #4852