Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention the http4s-armeria project on the Scala integration page #4920

Merged
merged 3 commits into from Jun 9, 2023

Conversation

danicheg
Copy link
Contributor

@danicheg danicheg commented Jun 3, 2023

Closes #4919

Copy link
Contributor

@ikhoon ikhoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @danicheg! ❤️

As a matter of fact, there are three distinct ways to integrate Armeria and Scala:

* by using the `armeria-scala` library;
* by using the [`http4s-armeria`](https://github.com/http4s/http4s-armeria) library;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In fact, we also have Tapir Armeria backend. https://tapir.softwaremill.com/en/latest/server/armeria.html
As you write ways to Armeria with Scala, it would be worth mentioning it. 😆

If it is, you think, out of the scope of this PR, I will add the section later.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh-oh, sorry, I wasn't aware of it :( It'd great if you could expand this section!

@ikhoon ikhoon added this to the 1.24.0 milestone Jun 4, 2023
Copy link
Contributor

@jrhee17 jrhee17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @danicheg 👍 🙇 👍

Copy link
Member

@minwoox minwoox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!!

Copy link
Member

@trustin trustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, @danicheg! 🙇

@trustin trustin merged commit bdfb14d into line:main Jun 9, 2023
9 of 10 checks passed
@danicheg danicheg deleted the scala-support-docs branch June 9, 2023 04:47
ikhoon pushed a commit to be-hase/armeria that referenced this pull request Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Not an issue] http4s-armeria reference in the docs
5 participants