Migrate to JUnit 5 from JUnit 4 in related to spring module

[heowc]

Motivation:

Starting from spring boot 2.4.0, junit5 is recommended. That's why we need to respond in the same way.

Modifications:

• org.junit.Test -> org.junit.jupiter.api.Test
• Remove org.junit.runner.RunWith
• Change some @AutoConfigureMetrics to @AutoConfigureObservability
• TestRule globalTimeout -> @Timeout(10)

Result:

• Closes Migrate JUnit 4 tests in Spring Boot integration modules to JUnit 5 #4788

[minwoox]

Could you also remove AutoConfigureMetrics in the actuator test classes? 😉
e.g. ArmeriaSpringActuatorAutoConfigurationSecureTest

[heowc]

Could you also remove AutoConfigureMetrics in the actuator test classes? 😉 e.g. ArmeriaSpringActuatorAutoConfigurationSecureTest

I tried to change it, but those annotations have changed since 3.0.0, so I didn't modify the code to work with 2.x.

[minwoox]

I tried to change it, but those annotations have changed since 3.0.0, so I didn't modify the code to work with 2.x.

Ah, you changed it in the test of it/spring/boo3-taomcat10. I didn't notice it. Please forget about the comment. 😓

[minwoox]

Thanks a lot for cleaning this up, @heowc!

[ikhoon]

Q: Is there a reason that you didn't migrate the tests in the actuator modules?

[heowc]

Q: Is there a reason that you didn't migrate the tests in the actuator modules?

XXX-actuator module seems to already work with junit5 🤔

[jrhee17]

Thanks for the cleanup! Left a minor comment 👍

[codecov]

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (f94002a) 74.20% compared to head (1dbead7) 74.19%.

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #5036      +/-   ##
============================================
- Coverage     74.20%   74.19%   -0.01%     
  Complexity    19464    19464              
============================================
  Files          1671     1671              
  Lines         71721    71721              
  Branches       9182     9182              
============================================
- Hits          53219    53216       -3     
- Misses        14180    14185       +5     
+ Partials       4322     4320       -2     

see 18 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jrhee17]

Thanks for the cleanup 👍 🙇 👍

[ikhoon]

Q: Is there a reason that you didn't migrate the tests in the actuator modules?

XXX-actuator module seems to already work with junit5 🤔

Right. I was confused.

[ikhoon]

Thanks for cleaning up, @heowc! ❤️

[trustin]

Thanks a lot, @heowc! 🙇