Add an abstraction layer for AnnotatedServiceConfigSetters
#5040
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
We recently had a consensus that we would like to provide a way to add context paths for a subset of services.
We will have to add another
AnnotatedServiceConfigSetters
for this purpose.By adding an abstraction layer, we could dedup some of the logic for building annotated services.
Modifications:
AbstractAnnotatedServiceConfigSetters
which extends setters.AnnotatedServiceBindingBuilder
andVirtualHostAnnotatedServiceBindingBuilder
now extendAbstractAnnotatedServiceConfigSetters
.Result: