Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an abstraction layer for AnnotatedServiceConfigSetters #5040

Merged
merged 3 commits into from Aug 28, 2023

Conversation

jrhee17
Copy link
Contributor

@jrhee17 jrhee17 commented Jul 17, 2023

Motivation:

We recently had a consensus that we would like to provide a way to add context paths for a subset of services.
We will have to add another AnnotatedServiceConfigSetters for this purpose.
By adding an abstraction layer, we could dedup some of the logic for building annotated services.

Modifications:

  • Introduce an AbstractAnnotatedServiceConfigSetters which extends setters.
  • AnnotatedServiceBindingBuilder and VirtualHostAnnotatedServiceBindingBuilder now extend AbstractAnnotatedServiceConfigSetters.

Result:

@jrhee17 jrhee17 added this to the 1.26.0 milestone Jul 17, 2023
@jrhee17 jrhee17 changed the title minimal impl Add an abstraction layer for AnnotatedServiceConfigSetters Jul 17, 2023
@jrhee17 jrhee17 marked this pull request as ready for review July 17, 2023 07:59
Copy link
Contributor

@ikhoon ikhoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @jrhee17!

Copy link
Member

@minwoox minwoox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice abstraction. Thanks!

@jrhee17 jrhee17 merged commit 13359e1 into line:main Aug 28, 2023
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants