New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX-5017 Add authorization metrics #5074
Conversation
a75f214
to
ec84a0c
Compare
core/src/main/java/com/linecorp/armeria/server/auth/AuthService.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/linecorp/armeria/server/auth/AuthService.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/linecorp/armeria/server/auth/AuthServiceBuilder.java
Outdated
Show resolved
Hide resolved
I don't see a test case that actually checks whether the metric is recorded. Could you add one? Thanks! 🙇 |
2605fa0
to
4997272
Compare
6a09452
to
586bc0e
Compare
836785f
to
ba55e14
Compare
ba55e14
to
25ef636
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, left a minor comment
core/src/main/java/com/linecorp/armeria/server/auth/AuthService.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry about the delay 😅 I think once test related comments are addressed this PR should be good for merging 🙇
core/src/test/java/com/linecorp/armeria/server/auth/AuthServiceTest.java
Outdated
Show resolved
Hide resolved
.addService(new AuthenticatedHttpJsonTranscodingTestService()) | ||
.enableHttpJsonTranscoding(true) | ||
.build(); | ||
.addService(new AuthenticatedHttpJsonTranscodingTestService()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mind reverting incorrect indentations in this file?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5074 +/- ##
===========================================
+ Coverage 0 74.04% +74.04%
- Complexity 0 20797 +20797
===========================================
Files 0 1801 +1801
Lines 0 76594 +76594
Branches 0 9762 +9762
===========================================
+ Hits 0 56715 +56715
- Misses 0 15257 +15257
- Partials 0 4622 +4622 ☔ View full report in Codecov by Sentry. |
56edf3f
to
9747a53
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry it took a while 😄 Looks good to me 👍 🙇 👍
core/src/main/java/com/linecorp/armeria/server/auth/AuthService.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/linecorp/armeria/server/auth/AuthService.java
Outdated
Show resolved
Hide resolved
grpc/src/main/java/com/linecorp/armeria/server/grpc/GrpcDecoratingService.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @yashmurty!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @yashmurty! 🚀👍
Motivation:
Fixing an open improvement issue. #5017
Modifications:
AuthService.java
file to useMoreMeters.newTimer
.Result:
The metrics would look like: