Fix incorrect local and remote address when using domain socket in abstract namespace #5096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stract namespace Related issue: line#5080 Motivation: `ServiceRequestContext.localAddress()` and `ServiceRequestContext.remoteAddress()` currently returns an `InetSocketAddress(0.0.0.0:1)` for domain sockets in abstract namespace. Modifications: - Updated `ChannelUtil` to use the parent channel's local address for server-side domain socket channels to retrieve their socket addresses reliably - Added a special hostname `<unknown>` to `HttpServerHandler.UNKNOWN_ADDR` so that it's less confusing Result: - `ServiceRequestContext` now returns the correct socket addresses when the request is being served via a domain socket in abstract namespace. - It should be easier to understand the situation when a similar issue (unknown address) arises again.
trustin
force-pushed
the
absract_namespace_address
branch
from
c2772db
to
a462145
Compare
chrisryan10
approved these changes
Aug 2, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #5096 +/- ##
============================================
- Coverage 74.19% 74.19% -0.01%
- Complexity 19469 19471 +2
============================================
Files 1672 1672
Lines 71749 71762 +13
Branches 9189 9189
============================================
+ Hits 53237 53243 +6
- Misses 14186 14193 +7
Partials 4326 4326
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #5080
Motivation:
ServiceRequestContext.localAddress()andServiceRequestContext.remoteAddress()currently returns anInetSocketAddress(0.0.0.0:1)for domain sockets in abstract namespace.Modifications:
ChannelUtilto use the parent channel's local address forserver-side domain socket channels to retrieve their socket addresses
reliably
<unknown>toHttpServerHandler.UNKNOWN_ADDRso that it's less confusing
Result:
ServiceRequestContextnow returns the correct socket addresses whenthe request is being served via a domain socket in abstract namespace.
(unknown address) arises again.