Include logback12 from logback module #5139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrhee17
force-pushed
the
bugfix/logback-module
branch
from
064428b
to
8d0b433
Compare
minwoox
reviewed
Aug 23, 2023
| @@ -1,4 +1,4 @@ | |||
| dependencies { | |||
| // Logback | |||
| api libs.logback12 | |||
| api project(':logback12') | |||
There was a problem hiding this comment.
Could you also check if the POM file is correctly created?
We can run logback12:generatePomFileForJarPublication task. 😉
There was a problem hiding this comment.
I've double-checked it with generatePomFileForJarPublication command and the POM file was correctly generated.
minwoox
approved these changes
Aug 23, 2023
trustin
approved these changes
Aug 23, 2023
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #5139 +/- ##
============================================
- Coverage 74.23% 74.22% -0.02%
+ Complexity 19811 19804 -7
============================================
Files 1698 1698
Lines 73093 73093
Branches 9359 9359
============================================
- Hits 54264 54251 -13
- Misses 14395 14411 +16
+ Partials 4434 4431 -3 ☔ View full report in Codecov by Sentry. |
jrhee17
added a commit
to jrhee17/armeria
that referenced
this pull request
Aug 24, 2023
* Update snapshot version to 1.25.1 (line#5137) * Include logback12 from logback module (line#5139) Motivation: @ikhoon pointed out that the `logback` module doesn't bring in the `logback12` module in the pom. Modifications: - Modified so that the `logback` module correctly declares the dependency. Result: - `logback` module contains the correct dependencies - Describe the consequences that a user will face after this PR is merged. <!-- Visit this URL to learn more about how to write a pull request description: https://armeria.dev/community/developer-guide#how-to-write-pull-request-description --> * Release note for 1.25.1 (line#5140)  * Fix flaky `MultipartEncoderTckTest.required_spec101...` (line#5136) Motivation: `MultipartEncoderTckTest.required_spec101_XXX` fails quite often. https://ge.armeria.dev/scans/tests?search.timeZoneId=Asia/Seoul&tests.container=com.linecorp.armeria.common.multipart.MultipartEncoderTckTest&tests.test=required_spec101_subscriptionRequestMustResultInTheCorrectNumberOfProducedElements ```java java.lang.AssertionError: Publisher com.linecorp.armeria.common.multipart.MultipartEncoder@3eec8583 produced no element after first `request` within 200 ms at org.testng.Assert.fail(Assert.java:98) at org.reactivestreams.tck.TestEnvironment.flopAndFail(TestEnvironment.java:285) at org.reactivestreams.tck.TestEnvironment$Receptacle.next(TestEnvironment.java:1047) at org.reactivestreams.tck.TestEnvironment$ManualSubscriber.nextElement(TestEnvironment.java:514) at org.reactivestreams.tck.TestEnvironment$ManualSubscriber.nextElement(TestEnvironment.java:510) at org.reactivestreams.tck.PublisherVerification$3.run(PublisherVerification.java:212) at org.reactivestreams.tck.PublisherVerification.activePublisherTest(PublisherVerification.java:1135) at org.reactivestreams.tck.PublisherVerification.required_spec101_subscriptionRequestMustResultInTheCorrectNumberOfProducedElements(PublisherVerification.java:204) ``` The failure couldn't be reproduced locally. I checked the log on the Gradle scan and it shows that the classes are initialized when the test starts. I guess JVM lazy class initialization and the Netty worker group initialization could affect the failure. Modifications: - Early initialize Netty worker group before starting the tests - Increase timeout Result: - Closes line#4554 --------- Co-authored-by: Trustin Lee <trustin@linecorp.com> * modify run for local repo experiment --------- Co-authored-by: Ikhun Um <ikhun.um@linecorp.com> Co-authored-by: Trustin Lee <trustin@linecorp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
@ikhoon pointed out that the
logbackmodule doesn't bring in thelogback12module in the pom.Modifications:
logbackmodule correctly declares the dependency.Result:
logbackmodule contains the correct dependencies