Support gRPC exception handler for client-side

[jrhee17]

Motivation:

This PR attempts to support GrpcExceptionHandlerFunction for gRPC client side

Modifications:

• Add GrpcClientBuilder.exceptionHandler which accepts a GrpcExceptionHandlerFunction
• Modify all GrpcStatus.fromThrowable(Throwable) calls to use GrpcStatus.fromThrowable(GrpcStatusFunction, RequestContext, Throwable, Metadata) instead

Result:

• Closes Allow custom gRPC status mapping rule in gRPC client #5347

[github-actions]

🔍 Build Scan® (commit: 7a44db6)

Job name	Status	Build Scan®
build-windows-latest-jdk-19	✅	https://ge.armeria.dev/s/qag2nw3qlomv4
build-self-hosted-jdk-8	✅	https://ge.armeria.dev/s/bx65covi3vina
build-self-hosted-jdk-19-snapshot-blockhound	✅	https://ge.armeria.dev/s/nrqqgnsleaf7e
build-self-hosted-jdk-17-min-java-17-coverage	✅	https://ge.armeria.dev/s/gg7c3n3uefdm4
build-self-hosted-jdk-17-min-java-11	✅	https://ge.armeria.dev/s/bojbdaahnb552
build-self-hosted-jdk-17-leak	✅	https://ge.armeria.dev/s/hq22o5gk3rjim
build-self-hosted-jdk-11	❌ (failure)	https://ge.armeria.dev/s/6paceieelb2pm
build-macos-12-jdk-19	✅	https://ge.armeria.dev/s/p34ggcnv4vhfu

[ikhoon]

Thanks, @jrhee17! 👍

[ikhoon]

Minor) Should we provide the default exception handler with this option?

[jrhee17]

Sorry, I don't think I understood your intention 😅

Do you mean you prefer that (ctx, cause, metadata) -> null is defined as the "DEFAULT" exception handler somewhere? (so that GrpcExceptionHandlerFunction is non-null overall?)

[minwoox]

I guess (ctx, cause, metadata) -> null is the default exception handler which returns null so that the status from statusFromThrowable is used.

armeria/grpc/src/main/java/com/linecorp/armeria/internal/common/grpc/GrpcStatus.java

Lines 115 to 122 in d30db0c

	if (exceptionHandler != null) {
	final Status status = exceptionHandler.apply(ctx, t, metadata);
	if (status != null) {
	return status;
	}
	}
	return statusFromThrowable(t);

I think we can explicitly call (ctx, cause, metadata) -> GrpcStatus.fromThrowable(cause) or leave a comment about why null is returned to make it clearer. 🤔

[jrhee17]

Updated as suggested 👍

[minwoox]

Looks great, thanks! 👍 👍 👍

[minwoox]

This isn't revised. 😉

[minwoox]

I guess (ctx, cause, metadata) -> null is the default exception handler which returns null so that the status from statusFromThrowable is used.

armeria/grpc/src/main/java/com/linecorp/armeria/internal/common/grpc/GrpcStatus.java

Lines 115 to 122 in d30db0c

	if (exceptionHandler != null) {
	final Status status = exceptionHandler.apply(ctx, t, metadata);
	if (status != null) {
	return status;
	}
	}
	return statusFromThrowable(t);

I think we can explicitly call (ctx, cause, metadata) -> GrpcStatus.fromThrowable(cause) or leave a comment about why null is returned to make it clearer. 🤔

[codecov]

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (3f54be0) 73.94% compared to head (7a44db6) 73.69%.
Report is 9 commits behind head on main.

Files	Patch %	Lines
...rmeria/internal/client/grpc/ArmeriaClientCall.java	81.81%	2 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #5351      +/-   ##
============================================
- Coverage     73.94%   73.69%   -0.26%     
- Complexity    20104    20107       +3     
============================================
  Files          1730     1741      +11     
  Lines         74161    74369     +208     
  Branches       9465     9483      +18     
============================================
- Hits          54841    54804      -37     
- Misses        14844    15030     +186     
- Partials       4476     4535      +59     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jrhee17]

Let me go ahead and merge this 🙇 Thanks for the review all