Support for Spring 6 HTTP interface

[ikhoon]

Motivation:

The Spring Framework 6 supports defining declarative HTTP services using Java interfaces like Feign.
That could be an alternative choice for Spring users instead of Retrofit.

Modifications:

• Add spring6 module to provide ArmeriaHttpExchangeAdapter.
• ArmeriaClientHttpRequest and ArmeriaClientHttpRequest are moved to Spring 6 module from the WebFlux module.
  • The WebFlux module now depends on Spring 6 to share the files.
• ClientRequest and ClientResponse in Spring 6 are used as a bridge to encode an object into HttpData and vice versa.

Result:

You can now create Spring 6 HTTP interface with Armeria WebClient.

import com.linecorp.armeria.client.WebClient;
import org.springframework.web.service.invoker.HttpServiceProxyFactory;

WebClient webClient = ...;
ArmeriaHttpExchangeAdapter adapter = ArmeriaHttpExchangeAdapter.of(webClient);
MyService service =
  HttpServiceProxyFactory.builderFor(adapter)
                         .build()
                         .createClient(MyService.class);

[github-actions]

🔍 Build Scan® (commit: 3d21a9f)

Job name	Status	Build Scan®
build-windows-latest-jdk-19	✅	https://ge.armeria.dev/s/5ehjkdcqs3ung
build-self-hosted-unsafe-jdk-8	✅	https://ge.armeria.dev/s/5vy4xhw7gl6kk
build-self-hosted-unsafe-jdk-19-snapshot-blockhound	✅	https://ge.armeria.dev/s/xkob5mizvwxrc
build-self-hosted-unsafe-jdk-17-min-java-17-coverage	✅	https://ge.armeria.dev/s/nfe2rixsx34eq
build-self-hosted-unsafe-jdk-17-min-java-11	✅	https://ge.armeria.dev/s/nf5kkv2ygkvla
build-self-hosted-unsafe-jdk-17-leak	❌ (failure)	https://ge.armeria.dev/s/dzxlyax7xd6ie
build-self-hosted-unsafe-jdk-11	❌ (failure)	https://ge.armeria.dev/s/qsjjuilcgf77i
build-macos-12-jdk-19	✅	https://ge.armeria.dev/s/syq3qiscat5ti

[codecov]

Codecov Report

Attention: Patch coverage is 81.20301% with 25 lines in your changes are missing coverage. Please review.

Project coverage is 74.04%. Comparing base (ccb29fe) to head (4692594).
Report is 2 commits behind head on main.

❗ Current head 4692594 differs from pull request most recent head 3d21a9f. Consider uploading reports for the commit 3d21a9f to get more accurate results

Files	Patch %	Lines
...eria/spring/client/ArmeriaHttpExchangeAdapter.java	76.47%	14 Missing and 6 partials ⚠️
...ring/client/ArmeriaHttpExchangeAdapterBuilder.java	76.92%	3 Missing ⚠️
.../armeria/spring/client/RequestAttributeAccess.java	80.00%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #5370       +/-   ##
===========================================
+ Coverage        0   74.04%   +74.04%     
- Complexity      0    20839    +20839     
===========================================
  Files           0     1805     +1805     
  Lines           0    76697    +76697     
  Branches        0     9776     +9776     
===========================================
+ Hits            0    56794    +56794     
- Misses          0    15279    +15279     
- Partials        0     4624     +4624     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[minwoox]

Looks pretty good. 👍
Left some questions.

[minwoox]

Left a question but it looks really great! Thanks!

[minwoox]

Question: So the decorator is not added to the client, the 123 will be ignored. Is that correct?
If so, is there any way to prevent this situation?

[ikhoon]

Right. It's up to the user how to use the request attribute.
In Spring, the value of @RequestAttribute is propagated to Filter.
It is an optional feature for which additional validation may not be needed.

[jrhee17]

Thanks! Changes look straightforward to me 👍 👍 👍

[minwoox]

Thanks a lot, @ikhoon!