Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add builder for Backoff #5483

Open
ikhoon opened this issue Mar 5, 2024 · 2 comments · May be fixed by #5488
Open

Add builder for Backoff #5483

ikhoon opened this issue Mar 5, 2024 · 2 comments · May be fixed by #5488
Labels
good first issue new feature

Comments

@ikhoon
Copy link
Contributor

ikhoon commented Mar 5, 2024 •
edited

Currently, Backoff can be created from a backoff spec or factory methods.
Builders for various backoff implementations to fluently build them should be useful.
Related work: https://github.com/googleapis/google-http-java-client/blob/9c47ab68b41353b2331568f5b3ef5610ea4b9feb/google-http-client/src/main/java/com/google/api/client/util/ExponentialBackOff.java#L266
@kth496
Copy link
Contributor

kth496 commented Mar 5, 2024

Hi @ikhoon, Can I take this on?

@ikhoon
Copy link
Contributor Author

ikhoon commented Mar 5, 2024

For sure. ❤️

@kth496 kth496 linked a pull request Mar 6, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add builder for Backoff kth496/armeria
2 participants
@ikhoon @kth496