Access logs are written within the Request Context

[jrhee17]

Motivation:

It is a common use case to use RequestContextExportingAppender together with AccessLogWriter. However, in order for RequestContextExportingAppender to work, the RequestContext must be available.

armeria/core/src/main/java/com/linecorp/armeria/common/logging/RequestContextExporter.java

Line 204 in 4bfa172

final RequestContext ctx = RequestContext.currentOrNull();

For this reason, I propose that config.accessLogWriter()::log be called with the RequestContext set on the calling thread

Modifications:

• Searched all references of config.accessLogWriter()::log and wrapped in a ctx.push call.

Result:

• access logs are written with the RequestContext set on the calling thread.

[github-actions]

🔍 Build Scan® (commit: 7ac7009)

Job name	Status	Build Scan®
build-windows-latest-jdk-19	✅	https://ge.armeria.dev/s/nx337vmd7qqxc
build-self-hosted-unsafe-jdk-8	✅	https://ge.armeria.dev/s/pcakawr4hhy5c
build-self-hosted-unsafe-jdk-19-snapshot-blockhound	✅	https://ge.armeria.dev/s/ypk2o6ilstk24
build-self-hosted-unsafe-jdk-17-min-java-17-coverage	✅	https://ge.armeria.dev/s/66gzzrqmijyi2
build-self-hosted-unsafe-jdk-17-min-java-11	✅	https://ge.armeria.dev/s/wqn334ttid6no
build-self-hosted-unsafe-jdk-17-leak	❌ (failure)	https://ge.armeria.dev/s/2cz533pligciw
build-self-hosted-unsafe-jdk-11	✅	https://ge.armeria.dev/s/2n3rna6igqqui
build-macos-12-jdk-19	✅	https://ge.armeria.dev/s/zurbbhljlslxg

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.03%. Comparing base (4bfa172) to head (7ac7009).

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #5500       +/-   ##
===========================================
+ Coverage        0   74.03%   +74.03%     
- Complexity      0    20797    +20797     
===========================================
  Files           0     1801     +1801     
  Lines           0    76577    +76577     
  Branches        0     9759     +9759     
===========================================
+ Hits            0    56694    +56694     
- Misses          0    15260    +15260     
- Partials        0     4623     +4623     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[minwoox]

👍 👍 👍

[ikhoon]

👍👍