Streamline native image config generation / Update native image config #5516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation:
- Generating the native image config currently requires more than one
manual steps not well-documented.
- We didn't update our native image config recently.
Modifications:
- Updated `README.md`
- `nativeImageConfig` task now merges the previously generated config,
so that we don't need to merge it manually.
- Added a new option `-Pscratch` that builds the config from scratch,
which is disabled by default.
- `nativeImageConfig` task now removes the comment patterns in
`resource-config.json` automatically.
- Added a few more filters to remove unnecessary entries in the
generated native image config.
- Updated the native image config
Result:
- Only one manual step left until automating native image config
generation
- Up-to-date native image config
thachlp
reviewed
Mar 18, 2024
| [ | ||
| { | ||
| "type":"agent-extracted", | ||
| "classes":[ |
There was a problem hiding this comment.
These files are automatically generated, so I think it doesn't really matter as long as it's auto-formatted. This PR actually added an auto-formatting step, which is why we see a lot of diffs in this file.
jrhee17
approved these changes
Mar 18, 2024
| @@ -26,6 +26,18 @@ plugins { | |||
| `jvm-toolchains` | |||
| } | |||
|
|
|||
| // If `-Pscratch` is specified, do not source the previously generated config at core/src/main/resources/META-INF/native-image | |||
| // otherwise, the previously generated config will be merged into the newly generated config. | |||
| val shouldGenerateFromScratch = project.findProperty("scratch").let { | |||
There was a problem hiding this comment.
Question) Would hasProperty be more simple (and require less explanation)?
Suggested change
| val shouldGenerateFromScratch = project.findProperty("scratch").let { | |
| val shouldGenerateFromScratch = project.hasProperty("scratch").let { |
There was a problem hiding this comment.
I wanted to make sure our build explicitly rejects the flags like -Pscratch=false, which would otherwise have been treated as true.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Modifications:
README.mdnativeImageConfigtask now merges the previously generated config, so that we don't need to merge it manually.-Pscratchthat builds the config from scratch, which is disabled by default.nativeImageConfigtask now removes the comment patterns inresource-config.jsonautomatically.Result: