Guess ExchangeType if it is not set in RequestOptions

[ikhoon]

Motivation:

ExchangeType is a hint for performance optimization. If no RequestOptions is set, it is inferred from the type of HttpRequest. However, a custom RequestOptions is set, ExchangeType is not inferred even if the RequestOptions.exchangeType() is null.

Modifications:

• Use ExchangeType.RESPONSE_STREAMING if RequestOptions.exchangeType() is null and HttpRequest is an instance of FixedStreamMessage.
• If none of the above conditions are met, the method defaults to returning ExchangeType.BIDI_STREAMING.

Result:

ExchangeType is guessed correctly even if RequestOptions is set.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.04%. Comparing base (ccb29fe) to head (8790698).
Report is 1 commits behind head on main.

❗ Current head 8790698 differs from pull request most recent head ff98952. Consider uploading reports for the commit ff98952 to get more accurate results

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #5517       +/-   ##
===========================================
+ Coverage        0   74.04%   +74.04%     
- Complexity      0    20798    +20798     
===========================================
  Files           0     1801     +1801     
  Lines           0    76576    +76576     
  Branches        0     9761     +9761     
===========================================
+ Hits            0    56701    +56701     
- Misses          0    15255    +15255     
- Partials        0     4620     +4620     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

🔍 Build Scan® (commit: ff98952)

Job name	Status	Build Scan®
build-windows-latest-jdk-19	✅	https://ge.armeria.dev/s/qaihjr52q6voc
build-self-hosted-unsafe-jdk-8	✅	https://ge.armeria.dev/s/klipzitjh5urw
build-self-hosted-unsafe-jdk-19-snapshot-blockhound	✅	https://ge.armeria.dev/s/y4yfpukpaymu2
build-self-hosted-unsafe-jdk-17-min-java-17-coverage	✅	https://ge.armeria.dev/s/fjogc5tzwkzho
build-self-hosted-unsafe-jdk-17-min-java-11	✅	https://ge.armeria.dev/s/bo5giymjyxdz2
build-self-hosted-unsafe-jdk-17-leak	✅	https://ge.armeria.dev/s/fi46dgrvgvlpo
build-self-hosted-unsafe-jdk-11	✅	https://ge.armeria.dev/s/jsq4qn2tca2x2
build-macos-12-jdk-19	✅	https://ge.armeria.dev/s/ioue4sshor7ai

[jrhee17]

Looks straightforward enough 👍 Thanks @ikhoon 🙇 👍 🙇

[jrhee17]

+ Please check the lint failures 🙇

[thachlp]

Updated to modification:

• If none of the above conditions are met, the method defaults to returning ExchangeType.BIDI_STREAMING.

Could you explain this default meaning?

[ikhoon]

Good question.
Armeria requests and responses are a stream that does not hold all messages. One variant is FixedStreamMessage which contains all objects at the creation time. Reactive stream processing for backpressure is not required for the unary message type.

Otherwise, we use a streaming ExchangeType to subscribe to the message one by one when a message is written to the wire.

My answer may not be sufficient to explain Armeria's stream processors. If you want to know more about that, please let us know.

[thachlp]

Good question. Armeria requests and responses are a stream that does not hold all messages. One variant is FixedStreamMessage which contains all objects at the creation time. Reactive stream processing for backpressure is not required for the unary message type.

Otherwise, we use a streaming ExchangeType to subscribe to the message one by one when a message is written to the wire.

My answer may not be sufficient to explain Armeria's stream processors. If you want to know more about that, please let us know.

Thanks for explaining to me 🙇
I just started learning Armeria :)

[minwoox]

Great, thanks!