Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close InputStream after marshalling gRPC messages #5523

Merged
merged 1 commit into from Mar 22, 2024

Conversation

ikhoon
Copy link
Contributor

@ikhoon ikhoon commented Mar 20, 2024

Motivation:

InputStreams returned by method.streamRequest() and method.streamResponse() were not closed after use. #5520

Modifications:

  • Use try-with-resource to close the InputStreams after use

Result:

Fixed a possible memory leak when a custom gRPC marshaler is used.

Motivation:

`InputStream`s returned by `method.streamRequest()` and
`method.streamResponse()` were not closed after use.
line#5520

Modifications:

- Use try-with-resource to close the `InputStream`s after use

Result:

Fixed a possible memory leak that could occur when a custom gRPC
marshaler is used.
@ikhoon ikhoon added the defect label Mar 20, 2024
@ikhoon ikhoon added this to the 1.28.0 milestone Mar 20, 2024
Copy link
Contributor

@jrhee17 jrhee17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍 👍

Copy link
Member

@minwoox minwoox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@minwoox minwoox merged commit 3963f1a into line:main Mar 22, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants