Handle a leak when thrift requests are aborted early

[jrhee17]

Motivation:

We received a report where thrift was leaking pooled byte buffers.
We use pooled byte buffers to create the thrift request in THttpClientDelegate assuming
that it will be released when sent on the wire for normal cases.

armeria/thrift/thrift0.13/src/main/java/com/linecorp/armeria/internal/client/thrift/THttpClientDelegate.java

Line 134 in 7f30250

final ByteBuf buf = ctx.alloc().buffer(128);

However, if any requests don't have a chance to reach the wire, they will leak the byte buffer.
I believe it is reasonable to assume that requests not decoded properly should be cleaned up. Hence, I propose we do an extra req.abort inside handlePreDecodeException.

Modifications:

• Modify handlePreDecodeException to accept an additional HttpRequest parameter
• Abort the request with the exception if exists

Result:

• Buffer leak reported in THttpClientDelegate #5481

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.06%. Comparing base (fadd348) to head (28a1938).
Report is 1 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #5535      +/-   ##
============================================
+ Coverage     74.04%   74.06%   +0.02%     
- Complexity    20851    20861      +10     
============================================
  Files          1807     1807              
  Lines         76757    76760       +3     
  Branches       9792     9793       +1     
============================================
+ Hits          56833    56852      +19     
+ Misses        15292    15283       -9     
+ Partials       4632     4625       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

🔍 Build Scan® (commit: 28a1938)

Job name	Status	Build Scan®
build-windows-latest-jdk-19	✅	https://ge.armeria.dev/s/pchp4nwjmm2rq
build-self-hosted-unsafe-jdk-8	✅	https://ge.armeria.dev/s/5s5e6ibj4elky
build-self-hosted-unsafe-jdk-19-snapshot-blockhound	✅	https://ge.armeria.dev/s/vg4dqcxvgvudu
build-self-hosted-unsafe-jdk-17-min-java-17-coverage	✅	https://ge.armeria.dev/s/zra2wzjxtfmbe
build-self-hosted-unsafe-jdk-17-min-java-11	✅	https://ge.armeria.dev/s/p5wki7oh3dcya
build-self-hosted-unsafe-jdk-17-leak	✅	https://ge.armeria.dev/s/emg6jfvgs5o3u
build-self-hosted-unsafe-jdk-11	✅	https://ge.armeria.dev/s/eogwcj5hi64jq
build-macos-12-jdk-19	✅	https://ge.armeria.dev/s/cojt37jboddms

[minwoox]

👍 👍 👍

[ikhoon]

Thanks, @jrhee17!