Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in document #5560

Merged
merged 3 commits into from Apr 4, 2024
Merged

Fix typo in document #5560

merged 3 commits into from Apr 4, 2024

Conversation

yeojin-dev
Copy link
Contributor

Fix typo

@CLAassistant
Copy link

CLAassistant commented Apr 3, 2024

CLA assistant check
All committers have signed the CLA.

@jrhee17 jrhee17 added this to the 1.28.0 milestone Apr 3, 2024
Copy link
Contributor

@jrhee17 jrhee17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍 👍

Copy link
Contributor

@ikhoon ikhoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

Copy link
Member

@minwoox minwoox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!
I push the revert commit for the index.mdx file so that #5445 isn't conflict. 😉

Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.11%. Comparing base (900002d) to head (f790f7c).
Report is 7 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5560      +/-   ##
============================================
- Coverage     74.13%   74.11%   -0.03%     
+ Complexity    20991    20982       -9     
============================================
  Files          1818     1819       +1     
  Lines         77233    77305      +72     
  Branches       9856     9876      +20     
============================================
+ Hits          57256    57292      +36     
- Misses        15309    15362      +53     
+ Partials       4668     4651      -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@minwoox minwoox merged commit 89c7cf4 into line:main Apr 4, 2024
17 of 18 checks passed
@yeojin-dev yeojin-dev deleted the fix-typo-in-document branch April 8, 2024 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants