Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support LbSubsetFallbackPolicy.NO_FALLBACK #5649

Merged
merged 1 commit into from
Apr 29, 2024
Merged

Support LbSubsetFallbackPolicy.NO_FALLBACK #5649

merged 1 commit into from
Apr 29, 2024

Conversation

minwoox
Copy link
Member

@minwoox minwoox commented Apr 29, 2024

Motivation
The default subset policy, LbSubsetFallbackPolicy.NO_FALLBACK, should be supported.

Modifications:

  • Support LbSubsetFallbackPolicy.NO_FALLBACK
  • Add toString methods for xDS classes
    Result:
  • XdsEndpointGroup now adheres to the LbSubsetFallbackPolicy.NO_FALLBACK policy.

@minwoox
Support LbSubsetFallbackPolicy.NO_FALLBACK
ee3260e 
Motivation
The default subset policy, `LbSubsetFallbackPolicy.NO_FALLBACK`, should be supported.

Modifications:
- Support `LbSubsetFallbackPolicy.NO_FALLBACK`

Result:
- `XdsEndpointGroup` now adheres to the `LbSubsetFallbackPolicy.NO_FALLBACK` policy.
@minwoox minwoox added the defect label Apr 29, 2024
@minwoox minwoox added this to the 1.28.4 milestone Apr 29, 2024
@github-actions GitHub Actions
Copy link
Contributor

🔍 Build Scan® (commit: ee3260e)

Job name Status Build Scan®
build-windows-latest-jdk-19 ✅ https://ge.armeria.dev/s/v2oapo7youkn2
build-self-hosted-unsafe-jdk-8 ✅ https://ge.armeria.dev/s/ppej6juf3wgh6
build-self-hosted-unsafe-jdk-19-snapshot-blockhound ✅ https://ge.armeria.dev/s/esrc4gcqn4i5q
build-self-hosted-unsafe-jdk-17-min-java-17-coverage ✅ https://ge.armeria.dev/s/aze7po6zxsdmu
build-self-hosted-unsafe-jdk-17-min-java-11 ✅ https://ge.armeria.dev/s/7fmpnmvrptm6w
build-self-hosted-unsafe-jdk-17-leak ✅ https://ge.armeria.dev/s/ur2bsfddock4y
build-self-hosted-unsafe-jdk-11 ✅ https://ge.armeria.dev/s/4hlaqwgfunbg2
build-macos-12-jdk-19 ✅ https://ge.armeria.dev/s/exw3krc3ybhjc

ikhoon
ikhoon approved these changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@ikhoon ikhoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍

jrhee17
jrhee17 approved these changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@jrhee17 jrhee17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍 👍

@minwoox minwoox merged commit ba8c75c into line:main Apr 29, 2024
16 checks passed
@minwoox minwoox deleted the lbSubsset_no_fallback branch April 29, 2024 09:59
@minwoox
Copy link
Member Author

minwoox commented Apr 29, 2024

Thanks for reviewing. 😉

minwoox added a commit that referenced this pull request Apr 29, 2024
@minwoox
Support LbSubsetFallbackPolicy.NO_FALLBACK (#5649)
fc1a01a 
Motivation
The default subset policy, `LbSubsetFallbackPolicy.NO_FALLBACK`, should be supported.

Modifications:
- Support `LbSubsetFallbackPolicy.NO_FALLBACK`
- Add `toString` methods for xDS classes
Result:
- `XdsEndpointGroup` now adheres to the `LbSubsetFallbackPolicy.NO_FALLBACK` policy.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trustin trustin trustin approved these changes

@ikhoon ikhoon ikhoon approved these changes

@jrhee17 jrhee17 jrhee17 approved these changes

Assignees
No one assigned
Labels
defect
Projects
None yet
Milestone
1.28.4
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@minwoox @trustin @ikhoon @jrhee17