-
Notifications
You must be signed in to change notification settings - Fork 900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shade Netty to simplify dependency conflicts against other systems #705
Comments
I would also like to use armeria with flink. I've already prepared change with this relocations: https://github.com/arkadius/armeria/tree/netty-shaded. Should I create PR or this change is someway controversial? |
@arkadius Good start, but we'd also need to:
Are you interested in making this change? It will be mostly about:
|
Yes, I'm interested in making this change. I'll analyse your proposal and will try to add this improvements. |
@arkadius Awesome! Please feel free to let us know if you have any questions or need any help. |
Closing. See #1168 for more information. |
A user want to use Armeria on Netty 4.0 based system (e.g. Apache Flink uses Netty 4.0) but because Armeria uses methods that is newly added in Netty 4.1, it causes NoSuchMethodException at runtime.
To solve this, he/she can relocate Netty4.1 by himself/herself.
But I think, it would be nice if we provide an armeria library that shade Netty dependency.
/cc @okdtsk
The text was updated successfully, but these errors were encountered: