Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support JPA 3.0 #160

Merged
merged 1 commit into from Jan 6, 2023
Merged

feat: Support JPA 3.0 #160

merged 1 commit into from Jan 6, 2023

Conversation

cj848
Copy link
Collaborator

@cj848 cj848 commented Jan 5, 2023

Motivation:

We must support the JPA 3.0 specification in #27.
As it is updated to Spring Boot 3, it cannot be used if it does not support the JPA 3.0 specification.
Since hibernate-reactive does not currently support the JPA 3.0 specification, it has not been updated separately.

-- korean
우리는 #27 에 있는 JPA 3.0 스펙을 지원하여야 합니다.
Spring Boot 3 으로 업데이트 되면서 JPA 3.0 스펙을 지원하지 않으면 사용할 수 없게 되었습니다.
hibernate-reactive 는 현재 JPA 3.0 스펙을 지원하지 않고 있기 때문에 별도 업데이트를 하지 않았습니다.

Modifications:

Added jakarta module used for JPA 3.0 support.
There's quite a bit of code duplication, but I've decided to take it in case of future fixes in the jdsl 3.0 version. Related discussion was made at #73 (comment)

We decided to set JDK 17 as the minimum required JDK specification.
As spring 6 goes up, JDK 17 becomes the minimum, and for projects using kotlin, JDK 17 is not too difficult to upgrade, so we will set JDK 17 as the minimum version.

The code base is almost the same, and jakarta projects have excluded coverage due to problems merging code coverage of the class of the same name in jacoco.

-- korean
JPA 3.0 지원에 사용되는 jakarta 모듈을 추가했습니다.
코드 중복이 상당히 많지만 향후 jdsl 3.0 버전의 수정에 대비해 감수하기로 했습니다. 관련 논의는 #73 (comment) 에서 이루어졌습니다.

JDK 17을 minimum required JDK 스펙으로 정하기로 했습니다.
spring 6이 올라가며 JDK 17이 minimum 이 되었고 kotlin 을 사용하는 프로젝트라면 JDK 의 업그레이드가 그리 어렵지 않기에 JDK 17 을 최소 버전으로 지정하기로 합니다.

코드 베이스가 거의 같기도 하고 jacoco 의 같은 이름의 클래스 code coverage 병합 문제로 인해 jakarta 프로젝트들은 coverage 를 제외했습니다.

#Result:
Users can use the kotlin-jdsl-jakarta module to use the JPA 3.0 specification and Spring Boot 3, Spring Data JPA 3, Spring 6 or later versions.

-- korean
유저는 kotlin-jdsl-jakarta 모듈을 사용하여 JPA 3.0 스펙과 Spring Boot 3, Spring Data JPA 3, Spring 6 이상의 버전을 사용할 수 있습니다.

Closes #. (If this resolves the issue.)

#27

@cj848 cj848 added the enhancement New feature or request label Jan 5, 2023
@CLAassistant
Copy link

CLAassistant commented Jan 5, 2023

CLA assistant check
All committers have signed the CLA.

@cj848 cj848 force-pushed the feature/jpa-3.0 branch 4 times, most recently from cb5f4ea to d438ed4 Compare January 5, 2023 06:32
@cj848 cj848 merged commit d8d6cd8 into line:main Jan 6, 2023
@cj848 cj848 deleted the feature/jpa-3.0 branch January 6, 2023 01:07
@Tankonyako
Copy link

yay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants