Add unit tests for Bean validation #22
Conversation
| constraintViolations.forEach( | ||
| constraintViolation -> assertThat(constraintViolation.getMessage()).isEqualTo(MUST_NOT_BE_BLANK) | ||
| ); |
There was a problem hiding this comment.
A little easier to read.
| constraintViolations.forEach( | |
| constraintViolation -> assertThat(constraintViolation.getMessage()).isEqualTo(MUST_NOT_BE_BLANK) | |
| ); | |
| assertThat(constraintViolations).extracting(ConstraintViolation::getMessage) | |
| .containsOnly(MUST_NOT_BE_BLANK); |
|
|
||
| final Set<ConstraintViolation<RegisterCredential>> constraintViolations = validator.validate(registerCredential); | ||
|
|
||
| assertThat(constraintViolations.size()).isEqualTo(3); |
There was a problem hiding this comment.
Using the AssertJ feature may make it a bit more readable.
| assertThat(constraintViolations.size()).isEqualTo(3); | |
| assertThat(constraintViolations).hasSize(3); |
| @BeforeEach | ||
| void setUp() throws IOException { | ||
| //Deep copy | ||
| registerCredential = objectMapper.readValue(objectMapper.writeValueAsString(origin), RegisterCredential.class); |
There was a problem hiding this comment.
Nice idea to load the base request first!
| @Test | ||
| void validateSuccessfulRequest() throws Exception { | ||
|
|
||
| mockMvc.perform(post(AUTH_CHALLENGE_URL_PATH) | ||
| .contentType(MediaType.APPLICATION_JSON) | ||
| .content(objectMapper.writeValueAsString(authChallengeRequest))) | ||
| .andExpect(status().isBadRequest()); | ||
| } |
There was a problem hiding this comment.
If the production code and the test code are packaged differently, we may not notice that there are tests.
How about writing them in ChallengeControllerTest as the same web layer test?
|
@seachicken |
| @@ -40,9 +40,10 @@ void validateIncompleteRequestWithBlank() { | |||
|
|
|||
| final Set<ConstraintViolation<AuthOptionRequest>> constraintViolations = validator.validate(authOptionRequest); | |||
|
|
|||
| assertThat(constraintViolations.size()).isEqualTo(1); | |||
| assertThat(constraintViolations).hasSize(1); | |||
| constraintViolations.forEach( | |||
There was a problem hiding this comment.
containsOnly checks all the elements of a collection, so we can get rid of forEach
There was a problem hiding this comment.
Oh, thanks! I fixed it.
What is this PR for?
Overview or reasons
Improve message validation check #20