Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text_highligh Specifies the same color ID #129

Open
BoredLen opened this issue Sep 26, 2022 · 1 comment
Open

Text_highligh Specifies the same color ID #129

BoredLen opened this issue Sep 26, 2022 · 1 comment

Comments

@BoredLen
Copy link

BoredLen commented Sep 26, 2022

Is it a security issue?

Not

What did you do?

The Colors directory in the SDK has many color values that are too generic, such as text_highlight, background, etc. This time our app has the same color ID as the Line SDK, which causes the LINE SDK colors to overwrite our app. We solved this problem in other ways

What did you expect?

I hope the Line SDK can consider this aspect of naming, such as adding a prefix or a relatively unique ID

What happened actually?

The same color ID causes the line color to cover our app
our app
color name="text_highlight">@color/ck_orange
line app
color name="text_highlight">#07bf3f

@plateaukao
Copy link
Member

Hi, @BoredLen
Thank you for the suggestion. We will enhance this part in next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants