Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitStream check does not reflect failure when Github Action fails. #30

Closed
jressey opened this issue Mar 7, 2023 · 3 comments
Closed
Labels
bug Something isn't working

Comments

@jressey
Copy link

jressey commented Mar 7, 2023

Describe the bug

gitStream job is hanging although it appears the job has failed.

To Reproduce

We added gitStream to the repo according to instructions earlier in the day. This PR was a typical change to the repo involving business logic.

  1. .cm file:
# -*- mode: yaml -*-

manifest:
  version: 1.0

automations:
  estimated_time_to_review:
    if:
      - true
    run:
      - action: add-label@v1
        args:
          label: "~{{ calc.etr }} min review"
          color: {{ 'E94637' if (calc.etr >= 20) else ('FBBD10' if (calc.etr >= 5) else '36A853') }}

calc:
  etr: {{ branch | estimatedReviewTime }}
is:
  formatting: {{ source.diff.files | isFormattingChange }}
  docs: {{ files | allDocs }}
  tests: {{ files | allTests }}
  1. PR url: https://github.com/Popmenu/popship/pull/153
  2. There are no changes relevant to gitStream
  3. 0acbaad346ddf08ba2638f5ef032648d60d19d34

Expected behavior

Success or failure are reported for the gitStream job.

Screenshots

image

Additional context

It is possible that this build was happening during the setup of gitStream for the same repo.

@jressey jressey added the bug Something isn't working label Mar 7, 2023
@vim-zz
Copy link
Collaborator

vim-zz commented Mar 7, 2023

@jressey do you have the Action log? Can you see any error in it?

@jressey
Copy link
Author

jressey commented Mar 7, 2023

@vim-zz

logs_251.zip

Running tag v1.133
PR: Popmenu/popship/pull/153
commit: 6afafb3b62e1344ef896b99c5473c00159699e24
fatal: bad revision 'master...origin/robszopinski/sc-48716/finish-cpln-answering-staging-qa-setup'
node:child_process:826
    err = new Error(msg);
          ^

Error: Command failed: git diff master...origin/robszopinski/sc-48716/finish-cpln-answering-staging-qa-setup -- .cm/*.cm
fatal: bad revision 'master...origin/robszopinski/sc-48716/finish-cpln-answering-staging-qa-setup'

    at checkExecSyncError (node:child_process:826:11)
    at execSync (node:child_process:900:15)
    at executeGitCommand (file:///src/utils/git.service.js:12:23)
    at isCmChanged (file:///src/utils/git.service.js:121:18)
    at file:///src/app.js:28:19
    at ModuleJob.run (node:internal/modules/esm/module_job:185:25)
    at async Promise.all (index 0)
    at async ESMLoader.import (node:internal/modules/esm/loader:281:24)
    at async loadESM (node:internal/process/esm_loader:88:5)
    at async handleMainPromise (node:internal/modules/run_main:65:12) {
  status: 128,
  signal: null,
  output: [
    null,
    Buffer(0) [Uint8Array] [],
    Buffer(99) [Uint8Array] [
      102,  97, 116,  97, 108,  58,  32,  98,  97, 100,  32, 114,
      101, 118, 105, 115, 105, 111, 110,  32,  39, 109,  97, 115,
      116, 101, 114,  46,  46,  46, 111, 114, 105, 103, 105, 110,
       47, 114, 111,  98, 115, 122, 111, 112, 105, 110, 115, 107,
      105,  47, 115,  99,  45,  52,  56,  55,  49,  54,  47, 102,
      105, 110, 105, 115, 104,  45,  99, 112, 108, 110,  45,  97,
      110, 115, 119, 101, 114, 105, 110, 103,  45, 115, 116,  97,
      103, 105, 110, 103,  45, 113,  97,  45, 115, 101, 116, 117,
      112,  39,  10
    ]

  ],
  pid: 30,
  stdout: Buffer(0) [Uint8Array] [],
  stderr: Buffer(99) [Uint8Array] [
    102,  97, 116,  97, 108,  58,  32,  98,  97, 100,  32, 114,
    101, 118, 105, 115, 105, 111, 110,  32,  39, 109,  97, 115,
    116, 101, 114,  46,  46,  46, 111, 114, 105, 103, 105, 110,
     47, 114, 111,  98, 115, 122, 111, 112, 105, 110, 115, 107,
    105,  47, 115,  99,  45,  52,  56,  55,  49,  54,  47, 102,
    105, 110, 105, 115, 104,  45,  99, 112, 108, 110,  45,  97,
    110, 115, 119, 101, 114, 105, 110, 103,  45, 115, 116,  97,
    103, 105, 110, 103,  45, 113,  97,  45, 115, 101, 116, 117,
    112,  39,  10
  ]
}
Error: Process completed with exit code 1.

@vim-zz
Copy link
Collaborator

vim-zz commented Mar 12, 2023

@jressey an issue was fixed, this should be ok now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants