Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Global http requests #22

Closed
grinsteindavid opened this issue May 19, 2021 · 2 comments
Closed

[bug] Global http requests #22

grinsteindavid opened this issue May 19, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@grinsteindavid
Copy link

grinsteindavid commented May 19, 2021

Hi, whenever I do a http request from a component that does not use this plugin in its story, then the response fails

something like this fails :

const response = await fetch(${url}?r=${Math.random()}).then(response => response.blob())

the stack errors said it was faker.js from this module, so I would prefer an option from parameters to enable this instead of being registered globally and preventing http requests to success

@nutboltu nutboltu added the bug Something isn't working label May 21, 2021
@nutboltu
Copy link
Collaborator

@grinsteindavid do you have any sandbox where you can reproduce the issue? Also It would be great if you share the stack trace as well. :)

@nutboltu
Copy link
Collaborator

@grinsteindavid My assumption is this issue occurs as the previous version of storybook-addon-mock doesn't support query parameters.

You can use the version 1.1.0. I am closing this issue. If it occurs again then we'll reopen it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants