Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a public constructor to StringCursor #2319

Merged
merged 3 commits into from Jan 11, 2023
Merged

Conversation

benoitryder
Copy link
Contributor

StringCursor fields being private is the only thing preventing a user to define its own EditableText, unless it directly wraps an existing one.

As an exemple, with this patch it is possible to wrap a RichText, implement few traits, and use it in a TextBox.

StringCursor fields being private is the only thing preventing a user to
define its own EditableText, unless it directly wraps an existing one.
Copy link
Member

@xStrom xStrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable, just need a slight change to the changelog.

CHANGELOG.md Show resolved Hide resolved
@xStrom xStrom added the S-waiting-on-author waits for changes from the submitter label Jan 10, 2023
Copy link
Member

@xStrom xStrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@xStrom xStrom merged commit b138b01 into linebender:master Jan 11, 2023
@xStrom xStrom removed the S-waiting-on-author waits for changes from the submitter label Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants