Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

derive size of text-containing widgets from size of their text #600

Closed
cmyr opened this issue Mar 4, 2020 · 1 comment
Closed

derive size of text-containing widgets from size of their text #600

cmyr opened this issue Mar 4, 2020 · 1 comment
Labels
enhancement adds or requests a new feature

Comments

@cmyr
Copy link
Member

cmyr commented Mar 4, 2020

Widgets like button and textbox currently have different methods for determining their size. Button defers to label, which is sized based on the contained text; and textbox uses a constant defined in the env.

Basically: any widget that contains text should have have its size based on the size of the underlying text, so that the widgets will resize correctly in response to changes in text size. This is important not just to make these widgets more readily customizable, but also to support things like adaptive text size, an important accessibility feature.

This is currently blocked on linebender/piet#134, which will give us the ability to measure the height of lines.

@cmyr cmyr added the enhancement adds or requests a new feature label Mar 4, 2020
@cmyr
Copy link
Member Author

cmyr commented Mar 18, 2021

Fixed as part of #1182

@cmyr cmyr closed this as completed Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement adds or requests a new feature
Projects
None yet
Development

No branches or pull requests

1 participant