Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Slack links in to Linen Links #565

Closed
cheeseblubber opened this issue Oct 20, 2022 · 8 comments
Closed

Convert Slack links in to Linen Links #565

cheeseblubber opened this issue Oct 20, 2022 · 8 comments
Assignees

Comments

@cheeseblubber
Copy link
Collaborator

When someone syncs Slack conversations into Linen it is useful to have the links be converted in to Linen URLs. Slack has a 90 day retention so if someone clicks on a link to Slack archive often times it disappears

@erinkcochran87
Copy link

Bump on this! This would be super, super helpful to have.

@erinkcochran87
Copy link

I see this was marked as completed, but no PR is referenced, nor is there a changelog. The URLs I see between Slack and Linen also don't look any different - am I missing something?

@emilos
Copy link
Contributor

emilos commented Jun 1, 2023

hey @erinkcochran87, thanks for checking. I think that @cheeseblubber was just cleaning up issues and marked this as done by accident. We definitely want to build this out :). We even discussed this like a week ago.

@emilos emilos reopened this Jun 1, 2023
@cheeseblubber
Copy link
Collaborator Author

@erinkcochran87 Sorry about that was doing a Github issues cleaning purge. We're working on a big release coming up this week and will reprioritize it. Most likely we'll do this next week!

@erinkcochran87
Copy link

Oh gosh, that's absolutely excellent! Thank you so much! <3

@emilos emilos assigned sandrodesouza and unassigned emilos Jun 20, 2023
@emilos
Copy link
Contributor

emilos commented Jun 27, 2023

hey @erinkcochran87, it took us a while to get to it, but I just merged the first version here. I've been testing this out in few communities and seems to work OK, but linking is tricky so I would highly appreciate if you could test it out on your end too.

For now, when you click, we'll try to detect if the thread is on our end already, and if it is, you're going to stay within linen vs going to the archived link, which can be broken due to the 90 day limit and/or other reasons.

Replacing the link is probably the long term way to go, but it's tricky for subdomains as subdomains can change in the future. We'll try to figure out best approach, at least for now old content will not get lost and will be linkable.

Thanks!

@erinkcochran87
Copy link

@emilos Wow, thanks so much! Just let my teammate (who implemented this for us) know about this. She'll be OOO for the next few weeks, but I'll try to give it a spin in the mean time. Thanks again for the response 🔥

@emilos
Copy link
Contributor

emilos commented Jun 28, 2023

@erinkcochran87 thanks! looking forward to the feedback :) I'll close the issue for now then just to keep things clean.

@emilos emilos closed this as completed Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

4 participants