Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icones disparaissent des wikis de WMF #1

Open
Pyb75 opened this issue Nov 8, 2019 · 5 comments
Open

Icones disparaissent des wikis de WMF #1

Pyb75 opened this issue Nov 8, 2019 · 5 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@Pyb75
Copy link

Pyb75 commented Nov 8, 2019

Sur les wikis de WMF et Firefox, le module fait disparaître les deux icones de la barre utilisateur située tout en haut.

Screenshot_2019-11-08 File Archipel Nm 1 2 1 - Elix ogv — Wikimedia Commons

@Ash-Crow
Copy link

Les icônes de la barre d'édition en mode wikicode disparaissent aussi.
Capture d’écran de 2019-11-27 11-17-59

@hugolpz
Copy link
Member

hugolpz commented Jul 23, 2022

Sign It inactive: icons background image visible
Screenshot_20220723_153707

Sign It active: icons background image messed
Screenshot_20220723_153841

Sign It inactive: icons background image visible
Screenshot_20220723_160509

Sign It active: icons background image messed
Screenshot_20220723_160402

Conclusion

It's a JS/CSS conflict between oojs-ui from the extension and from Mediawiki.

@hugolpz
Copy link
Member

hugolpz commented Jul 24, 2022

Some side effects on Lingualibre as well, since it also use oojs / oojs-ui.
Screenshot_20220724_195615

Screenshot_20220724_195634

@hugolpz
Copy link
Member

hugolpz commented Jul 25, 2022

Fixed. The way I did it is brutal :

  1. Both Wikimedia's websites and SignIt add-on use oojs
  2. SignIt's oojs come laters, the js edits all oo-ui path to call svg within the plugin.
  3. So I added oo-ui module's svgs icons into SignIt's ./lib/... path.

If oojs / oo-ui is upgraded, we need to upgrade the npm dependency.
If Wikimedia website drop oojs / oo-ui, all good, we can drop that folder.

Screenshot_20220725_181809

@hugolpz hugolpz closed this as completed Jul 25, 2022
@hugolpz hugolpz self-assigned this Aug 3, 2022
@hugolpz hugolpz added the bug Something isn't working label Aug 3, 2022
@hugolpz hugolpz added this to the 2022 milestone Aug 3, 2022
@hugolpz
Copy link
Member

hugolpz commented Aug 17, 2022

Not properly fixed. Better solution to find.

@hugolpz hugolpz reopened this Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants