Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Puppet4API Project Task 12] Understand Puppet Data Types #174

Closed
glennsarti opened this issue Sep 4, 2019 · 0 comments · Fixed by #175
Closed

[Puppet4API Project Task 12] Understand Puppet Data Types #174

glennsarti opened this issue Sep 4, 2019 · 0 comments · Fixed by #175
Milestone
0.22.0

Comments

@glennsarti
Copy link
Contributor

Track the work to add Puppet Data Type detection and surfacing to the user
glennsarti added a commit to glennsarti/puppet-editor-services that referenced this issue Sep 4, 2019
@glennsarti
(puppetlabsGH-174) Modify the sidecar to query DataTypes
90541d5 
Now that Puppet Strings understands Puppet Data Types, the sidecar can be
modified to query for them.  This commit:

* Updates the Sidecar Protocol to add Puppet DataTypes and DataType aliases
* Adds two new actions default_datatypes and workspace_datatypes. Note that
  these will only be populated if the puppetstrings feature flag is set.
* Updates the Puppet Strings helper to extract the data type info from the YARD
  objects
* Updates the retrieve_via_puppet_strings method to also be able to extract
  Puppet Data Types.
* Unfortunately there is no way to enumerate all of the "core" data types.
  As a workaround, we _can_ query the type factory class and instantiate all of
  the types the factory can produce.  While not perfect, it's a very good start.
glennsarti added a commit to glennsarti/puppet-editor-services that referenced this issue Sep 4, 2019
@glennsarti
(puppetlabsGH-174) Add tests to the sidecar query DataTypes
65801fe 
Now that the sidecar can query Data Types, we need to test this to ensure
consistent behaviour.
glennsarti added a commit to glennsarti/puppet-editor-services that referenced this issue Sep 4, 2019
@glennsarti
(puppetlabsGH-174) Modify the language server to enumerate data types
4fd6f0a 
Now that the sidecar can understand datatypes, the Language Server needs to be
updated to query and cache the results.  This commit:

* Adds the default and workspace queries for data types
* Updates the default and workspace aggregrate queries to also query datatypes
* Updates server startup to query for data types on start
* Updates the puppet helper to handle datatype loading and querying.
glennsarti added a commit to glennsarti/puppet-editor-services that referenced this issue Sep 4, 2019
@glennsarti
(puppetlabsGH-174) Update hover provider to provider datatypes support
130e8ee 
Now that the langauge server understands data types, this commit updates the
Hover Provider to emit data type information, and tests for this feature.
@glennsarti glennsarti mentioned this issue Sep 4, 2019
Merged
@glennsarti glennsarti added this to the 0.22.0 milestone Sep 4, 2019
Support Puppet 4 API and Puppet Agent 6 Features automation moved this from To do to Done Sep 6, 2019
jpogran added a commit that referenced this issue Sep 6, 2019
@jpogran
Merge pull request #175 from glennsarti/gh-174-understand-puppet-data…
90b4b52 
…types

(GH-174) Understand Puppet Data Types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.22.0
Development

Successfully merging a pull request may close this issue.

(GH-174) Understand Puppet Data Types glennsarti/puppet-editor-services
1 participant
@glennsarti