code completion for notify should not have ensure #67
Labels
Milestone
Comments
|
This is indeed a bug in PES. This naively adds |
glennsarti
added a commit
to glennsarti/puppet-editor-services
that referenced
this issue
Nov 9, 2018
Previously when a completion resolution request was received for a resource it
was hardcoded to return the name and ensure property. However not all resources
are ensurable, and some resources have other required properties or parameters.
This commit changes the resource completion to interrogate the Puppet Type and
then generate a more appropriate code snippet;
* The sidecar was extended to also track the isnamevar? value for resource
properties and parameters. This was needed by the completion resolver as
namevars should not appear in the code snippet as they come from the resource
name.
This also required tests to changed for this new property in the sidecar
protocol.
* The resource_type completion request was modified to dynamically generate the
snippet for resources;
- If the resource is ensurable, then the ensure parameter now appears the
first in the list, as per puppet-lint
- Properties/Parameters which are marked as required, are included in the code
snippet, except for those marked as a namevars. They implicitly come from
the resource name.
- The resource property/param names are sorted in alphabetical order (except
for ensure) as per puppet-lint
- The hash rockets of the generated snippet are now aligned as per puppet-lint
* Added tests for the new rsource completion style
* Fixed a minor bug which really only shoed itself during testing and wouldn't
normally be an issue in normal operation. The object being passed into the
`resolve` was being mutated inside the method. However the intended behaviour
of the method was output a new object and modify the input object in any way.
This commit instead clones the input object very early and then uses the clone
internally.
jpogran
pushed a commit
that referenced
this issue
Nov 13, 2018
(GH-67) Make resource completion smarter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
From:
puppetlabs/puppet-editor-syntax#5
Originally created by @TJM
What Versions are you running?
Editor Name and Version: VSCode 1.26.1
Theme: (dark?)
Document: test.pp
What You Are Seeing?
Error: Could not retrieve catalog from remote server: Error 500 on SERVER: Server Error: no parameter named 'ensure' (file: /etc/puppetlabs/code/environments/production/site/profile/manifests/test.pp, line: 106) on Notify[testing]
What is Expected?
the message I tried to notify out
How Did You Get This To Happen? (Steps to Reproduce)
in a puppet file type "notify" and hit "tab" when the code completion dialog comes up... resulting output is:
The "ensure" parameter is not valid.
The text was updated successfully, but these errors were encountered: