Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove detection of version file in client #177

Closed
jpogran opened this issue Oct 26, 2017 · 1 comment
Closed

Remove detection of version file in client #177

jpogran opened this issue Oct 26, 2017 · 1 comment
Assignees
@jpogran
Labels
extension
Milestone
0.7.2

Comments

@jpogran
Copy link
Contributor

jpogran commented Oct 26, 2017

No description provided.

@jpogran jpogran added this to the 0.8 milestone Oct 26, 2017
@jpogran jpogran self-assigned this Oct 26, 2017
@glennsarti
Copy link
Contributor

https://github.com/jpogran/puppet-vscode/blob/master/client/src/connection.ts#L268-L274

jpogran added a commit that referenced this issue Oct 26, 2017
@jpogran
(GH-177) Remove version file detection
81a0991 
This commit removes the check for the VERSION file inside the puppet
agent install path. This was originally used as a check that you had a
valid Puppet Agent path specified, but since there are variances whether
the file exists or not or where it's located in each package for each
platform, and it doesn't provide any actual value, it makes sense to
remove it.
glennsarti added a commit that referenced this issue Oct 26, 2017
@glennsarti
Merge pull request #178 from jpogran/GH-177-remove-version-file-detec…
6886aaf 
…tion

(GH-177) Remove version file detection
@jpogran jpogran mentioned this issue Oct 27, 2017
Closed
@jpogran jpogran closed this as completed Oct 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jpogran jpogran

Labels
extension
Projects
None yet
Milestone
0.7.2
Development

No branches or pull requests
2 participants
@jpogran @glennsarti