Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backslashes in File Path Do Not Display in Node Graph #180

Closed
michaeltlombardi opened this issue Oct 27, 2017 · 3 comments
Closed

Backslashes in File Path Do Not Display in Node Graph #180

michaeltlombardi opened this issue Oct 27, 2017 · 3 comments
Milestone

Comments

@michaeltlombardi
Copy link
Contributor

What Versions are you running?

  • OS Version: Windows 10
  • VSCode Version: 1.17.2
  • **Puppet Extension Version:**master (6886aaf)
  • Puppet Agent Version: 5.3.2 (puppet --version)
  • PDK Version (if applicable): Not installed.

What You Are Seeing?

When specifying a file resource and checking the node graph, backslashes are not displayed correctly, though forward slashes are.

image

image

image

What is Expected?

Paths to appear correctly in the node graph.

How Did You Get This To Happen? (Steps to Reproduce)

Clone, build, use the code from the screen shots.

Output Log

None generated.

@glennsarti
Copy link
Contributor

glennsarti commented Oct 30, 2017

So after some poking around. In the DOT language, backslashes in the label of a node a allowed and should not be seen as escaping characters. However renderers may, and in this case I believe that's what is happening. So this means the backslash munging needs to go into the client side, not language server as the server is outputting a valid DOT file.

See footnote # 1 in http://www.graphviz.org/doc/info/lang.html

glennsarti added a commit to glennsarti/puppet-vscode that referenced this issue Oct 30, 2017
Previously vis.jz sees backslashes as escape characters, however they are not in
the DOT language.  This commit escapes any backslash (double backslash) coming
from a valid DOT file, in preparation to be rendered by viz.js.
glennsarti added a commit to glennsarti/puppet-vscode that referenced this issue Oct 30, 2017
Previously vis.jz sees backslashes as escape characters, however they are not in
the DOT language.  This commit escapes any backslash (double backslash) coming
from a valid DOT file, in preparation to be rendered by viz.js.
jpogran added a commit that referenced this issue Nov 2, 2017
@jpogran jpogran added this to the 0.8.0 milestone Nov 2, 2017
@glennsarti
Copy link
Contributor

@michaeltlombardi Happy to close this issue?

@michaeltlombardi
Copy link
Contributor Author

Yes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants