Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove random port detection #274

Closed
jpogran opened this issue May 22, 2018 · 0 comments
Closed

Remove random port detection #274

jpogran opened this issue May 22, 2018 · 0 comments
Milestone
0.11.0

Comments

@jpogran
Copy link
Contributor

jpogran commented May 22, 2018 •
edited

Currently the extension determines a random unused port in order to communicate with the language server over tcp. In PR #279 stdio will become the default protocol, meaning using tcp will be mostly used by those doing advanced scenarios where they will be picking the host name and port and won't want something attempting to pick a port for them.

This issue suggests we remove the random port detection and rely on the configured port to connect if using tcp. This would avoid some of the problems in #240, while also addressing some of it.
jpogran added a commit to jpogran/puppet-vscode that referenced this issue Jun 21, 2018
@jpogran
(puppetlabsGH-274) Remove random port detection
72df29f 
This commit removes the code that detects and uses a random port for the
LanguageServer to run on. It instead parses the STDOUT message from the
LanguageServer for the port it is running on and uses that to connect.
If the user sets a port in the config, that is used instead of reading
the port from the LanguageServer.
jpogran added a commit to jpogran/puppet-vscode that referenced this issue Jun 21, 2018
@jpogran
(puppetlabsGH-274) Remove random port detection
5a6b22b 
This commit removes the code that detects and uses a random port for the
LanguageServer to run on. It instead parses the STDOUT message from the
LanguageServer for the port it is running on and uses that to connect.
If the user sets a port in the config, that is used instead of reading
the port from the LanguageServer.
jpogran added a commit to jpogran/puppet-vscode that referenced this issue Jun 22, 2018
@jpogran
(puppetlabsGH-274) Remove random port detection
3ae87da 
This commit removes the code that detects and uses a random port for the
LanguageServer to run on. It instead parses the STDOUT message from the
LanguageServer for the port it is running on and uses that to connect.
If the user sets a port in the config, that is used instead of reading
the port from the LanguageServer.
@jpogran jpogran added this to the 0.11.0 milestone Jun 25, 2018
glennsarti added a commit that referenced this issue Jun 26, 2018
@glennsarti
Merge pull request #294 from jpogran/GH-274-remove-random-port-detection
9357cc1 
(GH-274) Remove random port detection
@jpogran jpogran closed this as completed Jun 27, 2018
@jpogran jpogran mentioned this issue Jul 17, 2018
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.11.0
Development

No branches or pull requests
1 participant
@jpogran