Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow disabling of language server #335

Closed
snoopdouglas opened this issue Aug 3, 2018 · 3 comments
Closed

Allow disabling of language server #335

snoopdouglas opened this issue Aug 3, 2018 · 3 comments
Labels
feature
Milestone
0.15.0

Comments

@snoopdouglas
Copy link

I get this error whenever I open a .pp:

Could not find a valid Puppet installation at '/opt/puppetlabs/puppet'. While syntax highlighting and grammar detection will still work, intellisense and other advanced features will not.

I'm happy just using the syntax highlighting and grammar detection (as stated), and not having VS Code interact with a language server at all.

I seem to recall that there used to be an option to turn it off - but can no longer find it.
@jpogran
Copy link
Contributor

jpogran commented Aug 4, 2018

@snoopdouglas I'm pretty sure there was never an option to disable the language server. We recently added that error message as a way to better notify users when functionality would be degraded, whereas before there wasn't an obvious error message.

It's pretty reasonable to want to disable it, we'll add it to the board.

@glennsarti
Copy link
Contributor

+1. We will be revisiting the settings we currently have so this would be a good time.

jpogran added a commit to jpogran/puppet-vscode that referenced this issue Dec 5, 2018
@jpogran
(puppetlabsGH-335) Add option to disable language server
e104417 
This commit surfaces an option to disable loading the Puppet Language
Server, while still allowing the features that do not require a language
server. The first time this option is set, the user will be presented
with a message explainging what they turned off with an option to not
show this message again. The message won't be shown next time if the
user presses the button.
@jpogran jpogran added this to To do in 0.15.0 Marketplace Release via automation Dec 5, 2018
@jpogran jpogran added this to the 0.15.0 milestone Dec 5, 2018
@jpogran
Copy link
Contributor

jpogran commented Dec 5, 2018

@snoopdouglas just letting you know, we're planning on adding this to the next release.

@jpogran jpogran mentioned this issue Dec 6, 2018
Merged
0.15.0 Marketplace Release automation moved this from To do to Done Dec 6, 2018
michaeltlombardi added a commit that referenced this issue Dec 6, 2018
@michaeltlombardi
Merge pull request #442 from jpogran/GH-335-option-to-disable-languag…
3f1ad20 
…eserver

(GH-335) Add option to disable language server
@jpogran jpogran removed this from Done in 0.15.0 Marketplace Release Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
0.15.0
Development

No branches or pull requests
3 participants
@jpogran @snoopdouglas @glennsarti