Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Puppet DAG svg to match light and dark theme #546

Closed
jpogran opened this issue Aug 14, 2019 · 0 comments · Fixed by #547
Closed

Update Puppet DAG svg to match light and dark theme #546

jpogran opened this issue Aug 14, 2019 · 0 comments · Fixed by #547
Assignees
@jpogran
Labels
bug
Milestone
0.20.0

Comments

@jpogran
Copy link
Contributor

jpogran commented Aug 14, 2019

The existing pdk new module icon is set with an amber avg. The icon should match the best it can to light and dark themes, which keeps it in line with the style guideline of vscode
@jpogran jpogran self-assigned this Aug 14, 2019
@jpogran jpogran added the bug label Aug 14, 2019
@jpogran jpogran added this to To do in 0.20.0 Marketplace Release via automation Aug 14, 2019
@jpogran jpogran added this to the 0.20.0 milestone Aug 14, 2019
jpogran added a commit to jpogran/puppet-vscode that referenced this issue Aug 14, 2019
@jpogran
(puppetlabsGH-546) Update Puppet DAG svg icon
2bf2daa 
This commit adds a dag svg that matches dark and light themes.
@jpogran jpogran mentioned this issue Aug 14, 2019
Merged
0.20.0 Marketplace Release automation moved this from To do to Done Aug 15, 2019
jpogran added a commit that referenced this issue Aug 15, 2019
@jpogran
Merge pull request #547 from jpogran/GH-546-update-dag-svg-icon
9c2a95d 
(GH-546) Update Puppet DAG svg icon
@jpogran jpogran removed this from Done in 0.20.0 Marketplace Release Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jpogran jpogran

Labels
bug
Projects
None yet
Milestone
0.20.0
Development

Successfully merging a pull request may close this issue.

(GH-546) Update Puppet DAG svg icon jpogran/puppet-vscode
1 participant
@jpogran