New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hover and go to defintion not working as expected #605
Milestone
Comments
Hrmm I think I can see a problem.
The setting should be |
Yeah, looks like https://github.com/lingua-pupuli/puppet-vscode/blob/e1c97fedaa2a1672b7cbd7b2e9f3855d402c52c5/src/helpers/commandHelper.ts#L160 needs some changing. And I (git) blame myself for that one 😄 |
glennsarti
added a commit
to glennsarti/puppet-vscode
that referenced
this issue
Jan 17, 2020
Previously when passing through a module path to the language server it would use the puppet setting `modulePath` however this is not cased correctly. This commit uses the correct `modulepath` puppet setting.
jpogran
added a commit
that referenced
this issue
Jan 17, 2020
(GH-605) Use correct setting name for module path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What Versions are you running?
OS Version: macOS 10.14.6
VSCode Version: 1.41.1
Puppet Extension Version: 0.22.0
PDK Version: 1.15.0
What You Are Seeing?
Hover info and go to definition is not working for modules pulled in when onceover runs. I have the following in
.vscode/settings.json
within my control repo:That directory is populated when I run onceover like so:
What is Expected?
Hovering over a class or defined type of a module that is installed locally should produce informtion in a popup
Right clicking and selecting Go to Defintion should take me to the code associated with a class or defined type in a locally installed module.
How Did You Get This To Happen? (Steps to Reproduce)
I reproduced it by opening
site/profile/manifests/pe/master.pp
in my control repo and mousing over and right clicking on both parts ofprofile_metadata::service
(parts being either side of the::
).Output Log
From
Log(Extension Host)
:From
Puppet
Debug Log
The text was updated successfully, but these errors were encountered: