Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Numpy<1.22 requirement, could we upgrade it? #14

Closed
CarlaFernandez opened this issue Nov 28, 2022 · 3 comments
Closed

Numpy<1.22 requirement, could we upgrade it? #14

CarlaFernandez opened this issue Nov 28, 2022 · 3 comments

Comments

@CarlaFernandez
Copy link

First of all, thank you for this amazing project, it has really sped up my team's shap execution.

My problem arises because the numpy<1.22 restriction causes conflicts with other packages we use.

In your setup.py code it says that this restriction is due to using numba, but in their own setup.py the minimum numpy version is 1.18 and there is no maximum version requirement. In fact, I've been able to upgrade numpy's version after installing fasttreeshap in a clean environment and have had no problem at all during my test executions (using numpy==1.23.5). This is how I setup the environment on Windows 10:

$ python -m venv venv_fasttreeshap
$ venv_fasttreeshap\Scripts\activate
$ pip install fasttreeshap
$ pip install --upgrade numpy==1.23.5

It throws the following error, but pip is finaly able to install it anyway:

ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
fasttreeshap 0.1.2 requires numpy<1.22, but you have numpy 1.23.5 which is incompatible.

Do you think you could upgrade the numpy version in the install_requires section of setup.py, so that it's easier to combine fasttreeshap with other packages?

Thank you!

@CarlaFernandez
Copy link
Author

Just to add, this is very important to us, since it is blocking some tasks regarding the use of our packages

@jlyang1990
Copy link
Collaborator

Hi, thanks for your kind words for this package. I have removed the numpy version restriction in setup.py and released a new version 0.1.3. Let me know if you still have issues in package installation.

@CarlaFernandez
Copy link
Author

Hi @jlyang1990 , thank you for such a quick response. Indeed our installation issues have been solved by this simple change :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants