This repository has been archived by the owner on Feb 17, 2021. It is now read-only.
Fix StackLayout fillEqualSpacing distribution with spacing #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! I haven't looked at the issue yet, but this PR will unit need tests before it is mergeable. |
|
Thank you for adding unit tests. I'm curious, why doesn't this PR have the automatic CI verification like the other PRs do? |
|
@staguer Great question, I don't really know though. As you can see this pull is from a |
|
It looks like Travis thinks it has detected abuse: I contacted Travis support to see what is going on. |
|
@domasn Travis support says the abuse flag has been removed. Please push an empty commit or rebase against master to trigger a new build. |
Pull master
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
StackLayout.distributionConfigand calculates theaxisSpacingtaking into account the spaces that were already added during themeasurementphase. ActualexcessAxisLengthfor.fillEqualSpacingis increased bynumberOfSpaces * spacingso it can be redistrubuted.See issue #159