Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make selector connect() non-blocking for SSL connections #297

Closed
pnarayanan opened this issue May 13, 2016 · 1 comment
Closed

Make selector connect() non-blocking for SSL connections #297

pnarayanan opened this issue May 13, 2016 · 1 comment
Assignees
Labels

Comments

@pnarayanan
Copy link
Contributor

pnarayanan commented May 13, 2016

Currently, for connections over SSL, the ambry selector returns an established connection after a poll even before the handshake is completed. This is not very useful as the caller will then have to repeatedly check outside of the selector poll on whether the handshake is complete, which is not ideal.

Instead, let the selector do the work as part of the poll. The selector should only return a connection after the connection is established and the handshake is complete. If the handshake does not complete for any reason, then it should be treated as a connection establishment failure. This way the callers of the selector can be agnostic to SSL, and can interact with the selector in a completely non-blocking way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants