Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows customization in the Flink State binding #113

Merged
merged 4 commits into from
Feb 28, 2024

Conversation

xinyuiscool
Copy link

This patch allows LinkedIn to extend the state binding in FlinkStateInternals to support configs such as TTL.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@github-actions github-actions bot added the build label Feb 28, 2024
Copy link

@alnzng alnzng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Looks like we will implement the customization in beam-runner seprately, right?

@xinyuiscool
Copy link
Author

LGTM. Looks like we will implement the customization in beam-runner seprately, right?

Right, that's the plan. We will add our custom logic for ttl there.

@xinyuiscool xinyuiscool merged commit 54cd5d1 into linkedin:li_trunk Feb 28, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants