Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there a final jar available with all dependency jars in jfrog #2151

Open
sappusaketh opened this issue May 15, 2024 · 5 comments
Open

Is there a final jar available with all dependency jars in jfrog #2151

sappusaketh opened this issue May 15, 2024 · 5 comments

Comments

@sappusaketh
Copy link

sappusaketh commented May 15, 2024

I have downloaded cruise control , core and metrics jar from jfrog now I m trying to start cruise control with ./kafka-cruise-control-start.sh config/cruisecontrol.properties
but getting error

Exception in thread "main" java.lang.NoClassDefFoundError: org/slf4j/LoggerFactory
        at com.linkedin.kafka.cruisecontrol.KafkaCruiseControlMain.<clinit>(KafkaCruiseControlMain.java:18)
Caused by: java.lang.ClassNotFoundException: org.slf4j.LoggerFactory
        at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(Unknown Source)
        at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(Unknown Source)
        at java.base/java.lang.ClassLoader.loadClass(Unknown Source)
        ... 1 more

I think its because dependency jars are missing in class path anyway to download jars from jfrog and start cruise control?

@sappusaketh sappusaketh changed the title Is there a final jar available with all dependnecy jars in jfrog Is there a final jar available with all dependency jars in jfrog May 15, 2024
@marcelloromani
Copy link

What worked in my experience is performing the build before attempting to start CC with the shell script.

@sappusaketh
Copy link
Author

ya currently doing that but trying to see if I can reduce my build time by downloading already built jar

@marcelloromani
Copy link

I don't think build time is the issue here. How many times do you need to build CC's jars? Once per version. If you need to re-build CC every time you deploy then you have an issue in your pipeline.
Just build CC, store the resulting jars somewhere and consume them.

@sappusaketh
Copy link
Author

sappusaketh commented May 20, 2024

How many times do you need to build CC's jars? Once per version

Its once per version but My docker file do have other components like CC UI and nginx and if I have to change anything in dockerfile I m building the jars

Other option I considered is building CC in to its own docker image and reference it in my docker file which has other components but that will add additional things to manage in my cicd so planning to see if there is a way I can reduce build times during docker build using existing jars published to jfrog

@marcelloromani
Copy link

We solved the issue by having one repository build and publishing the jars.
Another repo uses those jars and adds CC UI and other minor bits that we need in our specific use case.
In other words, separate building CC and building other stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants