Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support map fieldType for @Searchable pdl annotation #2871

Closed
amorskoy opened this issue Jul 13, 2021 · 3 comments
Closed

Support map fieldType for @Searchable pdl annotation #2871

amorskoy opened this issue Jul 13, 2021 · 3 comments
Labels
feature-request Request for a new feature to be added

Comments

@amorskoy
Copy link

amorskoy commented Jul 13, 2021

Taking DatasetProperties.pdl as en example.
At this moment, I have no chance to search inside customProperties (inherited from CustomProperties.pdl).

Thus, I can not to search like "Find dataset having property 'sales_person' equal to Andrey ".

I may suppose, that search by properties is expected to be a common use case for metadata consumers

@amorskoy amorskoy added the feature-request Request for a new feature to be added label Jul 13, 2021
@shirshanka
Copy link
Contributor

Hi @amorskoy this is a common request, thanks for making it :)

One thing we want to be careful about is auto-indexing each key by default because it could lead to an explosion in terms indexed in elastic, e.g. if someone is logging a high cardinality key like "job-id" or a very verbose key like "dag-details" in Airflow etc.
We're thinking about a safe way to introduce this capability. @dexter-mh-lee will reply back on this issue.

@dexter-mh-lee
Copy link
Contributor

@amorskoy Sorry about the late reply. This feature was added a month ago, where you can search for "key1=value1" query to find entities with the property. For efficiency reasons, we only support case-insensitive exact matches and values that are less than 200 characters

@maggiehays
Copy link
Collaborator

Hi folks,

We are now managing feature requests through our new portal to improve visibility & prioritize work into our public roadmap. If this request is still relevant, please create a new issue so we can gauge current interest from the Community & prioritize work accordingly.

We'll close out this issue in the meantime. Feel free to reach out to me on DataHub Slack with any questions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for a new feature to be added
Projects
None yet
Development

No branches or pull requests

4 participants