Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(gms): reorganize GMS factory namespace #1916

Merged
merged 1 commit into from Oct 6, 2020
Merged

refactor(gms): reorganize GMS factory namespace #1916

merged 1 commit into from Oct 6, 2020

Conversation

mars-lan
Copy link
Contributor

@mars-lan mars-lan commented Oct 6, 2020

Fixes #1658

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@nagarjunakanamarlapudi nagarjunakanamarlapudi added the hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/ label Oct 6, 2020
@mars-lan mars-lan mentioned this pull request Oct 6, 2020
Merged
4 tasks
@mars-lan mars-lan merged commit 0f68f86 into datahub-project:master Oct 6, 2020
@mars-lan mars-lan mentioned this pull request Oct 9, 2020
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jywadhwani jywadhwani jywadhwani approved these changes

Assignees

@jywadhwani jywadhwani

Labels
hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reorganize GMS factory namespace
3 participants
@mars-lan @jywadhwani @nagarjunakanamarlapudi