Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(React): Search page UI improvements, 'all' entity search. #2140

Merged
merged 15 commits into from Feb 25, 2021
Merged

feat(React): Search page UI improvements, 'all' entity search. #2140

merged 15 commits into from Feb 25, 2021

Conversation

jjoyce0510
Copy link
Collaborator

@jjoyce0510 jjoyce0510 commented Feb 24, 2021 •
edited

As seen in the recent townhall!

Scope
These changes affect the React App.

Changes

  1. Update SearchPage to include tabs with icons
  2. Added "All" tab to search page, showing grouped entity search results.
  3. Moved the search filter experience to a modal.
  4. Add platforms icons for looker, hive, kafka, hdfs. These should be pushed from the server (coming soon).
  5. Misc style cleanups.
  6. Fixed bug in search results pagination.

Screenshots
Screen Shot 2021-02-23 at 9 45 01 PM
Screen Shot 2021-02-23 at 9 45 15 PM
Screen Shot 2021-02-23 at 9 45 26 PM
Screen Shot 2021-02-23 at 9 55 31 PM

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@jjoyce0510 jjoyce0510 changed the title Search page UI improvements feat(React): Search page UI improvements, 'all' entity search. Feb 24, 2021
shirshanka
shirshanka approved these changes Feb 25, 2021
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shirshanka shirshanka merged commit 606a5af into datahub-project:master Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

@gabe-lyons gabe-lyons gabe-lyons approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jjoyce0510 @shirshanka @gabe-lyons