Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingestion): nullable types and timestamp precision #2212

Merged
merged 2 commits into from Mar 11, 2021
Merged

fix(ingestion): nullable types and timestamp precision #2212

merged 2 commits into from Mar 11, 2021

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Mar 11, 2021

  • add support for nullable column types in SQL ingestion
  • fix a bug that would cause timestamp precision loss
  • mock time.time during tests for consistency

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

shirshanka
shirshanka approved these changes Mar 11, 2021
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shirshanka shirshanka merged commit 4e15fee into datahub-project:master Mar 11, 2021
@hsheth2 hsheth2 deleted the nullable branch November 10, 2022 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hsheth2 @shirshanka