Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(business_glossary): add business glossary entity in frontend-graphql layer #2485

Merged
merged 1 commit into from May 12, 2021
Merged

feat(business_glossary): add business glossary entity in frontend-graphql layer #2485

merged 1 commit into from May 12, 2021

Conversation

shubham49
Copy link
Contributor

@shubham49 shubham49 commented May 3, 2021 •
edited

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

search_dataset_linked_term

resolve #2142
This PR is dependent on #2228

@shubham49 shubham49 changed the title feat(business_glossary): add business glossary entity in frontend layer feat(business_glossary): add business glossary entity in frontend-graphql layer May 3, 2021
gabe-lyons
gabe-lyons reviewed May 11, 2021
View reviewed changes
Copy link
Contributor

@gabe-lyons gabe-lyons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good start- I notice that you did not add the glossary term property to the dataset entity in gms. Did you plan on adding that as a followup, or will you add that in this PR as well?

@shubham49
Copy link
Contributor Author

shubham49 commented May 11, 2021 •
edited

yes @gabe-lyons that will be part of followup PR

gabe-lyons
gabe-lyons reviewed May 11, 2021
View reviewed changes
Copy link
Contributor

@gabe-lyons gabe-lyons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great- this PR looks good then. Were you able to test it?

@shubham49
Copy link
Contributor Author

shubham49 commented May 11, 2021 •
edited

tested 1 of the query(SearchResults) by getting dataset linked to business term in the UI(screenshot attached in description).
For other queries tested through postman and in the followup PRs(#2517 ) we will be using these queries

shirshanka
shirshanka approved these changes May 12, 2021
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shirshanka shirshanka merged commit 95782b1 into datahub-project:master May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabe-lyons gabe-lyons gabe-lyons left review comments

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implementation of Business Glossary
4 participants
@shubham49 @shirshanka @gabe-lyons @gargshubham49